feat(eslint-plugin-react-hooks): merge rule from eslint-plugin-react-compiler into react-hooks plugin
#32416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the compiler plugin is going to be merged into the hooks plugin,, and ultimately decomposed into several more rules, it would be good to start creating a more traditional folder structure for the plugin. This change just moves the rules into a `rules` folder.
… entry point This change adds an export for `type Logger` from the `Entrypoint` module, to the root entrypoint for the package. This allows us to access it from the eslint-plugin-react-hooks package more easily.
This change adds the new dependencies needed for merging the react compiler plugin in.
michaelfaith
force-pushed
the
feat/merge-compiler-eslint-plugin
branch
from
185347d to
bf841c6
Compare
michaelfaith
force-pushed
the
feat/merge-compiler-eslint-plugin
branch
from
bf841c6 to
0b1f3a0
Compare
michaelfaith
force-pushed
the
feat/merge-compiler-eslint-plugin
branch
from
0b1f3a0 to
1e2d02b
Compare
michaelfaith
force-pushed
the
feat/merge-compiler-eslint-plugin
branch
from
1e2d02b to
dfd79bd
Compare
michaelfaith
added a commit
to michaelfaith/react
that referenced
this pull request
Feb 22, 2025
In preparation for the merging of the compiler plugin into this one (facebook#32416), this change proactively updates the plugin's `engines` declaration to require Node versions greater than or equal to 18 BREAKING CHANGE
michaelfaith
added a commit
to michaelfaith/react
that referenced
this pull request
Feb 22, 2025
In preparation for the merging of the compiler plugin into this one (facebook#32416), this change proactively updates the plugin's `engines` declaration to require Node versions greater than or equal to 18 BREAKING CHANGE
michaelfaith
force-pushed
the
feat/merge-compiler-eslint-plugin
branch
from
5261b0f to
f920d88
Compare
Update unit tests to use v8 rule tester for compiler tests
…e specific dep This change reverts the attempt to use the compiler source directly as part of unit testing, and instead installs an already published version of the package. The implication here is that it's not possible to consume unreleased / unpublished changes to the compiler in the eslint plugin. There's a pretty big disconnect between packages in the `compiler` folder and everything. So bridging that gap will take some additional work.
michaelfaith
force-pushed
the
feat/merge-compiler-eslint-plugin
branch
from
f920d88 to
6cd87fc
Compare
michaelfaith
force-pushed
the
feat/merge-compiler-eslint-plugin
branch
from
79b148c to
639cd8f
Compare
michaelfaith
force-pushed
the
feat/merge-compiler-eslint-plugin
branch
from
639cd8f to
011250b
Compare
michaelfaith
force-pushed
the
feat/merge-compiler-eslint-plugin
branch
from
011250b to
ab2a7e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change merges the
react-compilerrule fromeslint-plugin-react-compilerinto theeslint-plugin-react-hooksplugin. In order to do the move in a way that keeps commit history with the moved files, but also no remove them from their origin until a future cleanup change can be done, I did thegit mvfirst, and then recreated the files that were moved in their original places, as a separate commit. Unfortunately GH shows the moved files as new instead of the ones that are truly new. But in the IDE andgit blame, commit history is intact with the moved files.Since this change adds new dependencies, and one of those dependencies has a higher
enginesdeclaration fornodethan what the plugin currently has, this is technically a breaking change and will have to go out as part of a major release.Related Changes
enginesdeclaration #32458