Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to multiple files upload #1431

Closed
wants to merge 2 commits into from

Conversation

nossila
Copy link

@nossila nossila commented Oct 27, 2016

A suggestion was made on #586 but I thought using:

type FileMap = {[key: string]: File | FileList};

was a better idea since I would not need write a loop through the FileList (since its what is provided by the file input's API) to construct an array of files every time I need to send multiple files to a Mutation, this way Relay will handle it for me, I just need to write:

class AttachMultipleDocumentsMutation extends Relay.Mutation {
  getFiles() {
    return {
      files: this.props.files,
    };
  }
}
class FilesUploader extends React.Component {
  handleSubmit() {
    Relay.Store.commitUpdate(
      new AttachMultipleDocumentsMutation({file: this.refs.fileInput.files})
    );
  }
}

A suggestion was made on facebook#586 but I thought using FileList instead of [File] was a better idea since I would not need to loop through the FileList (since its what is provided the HTML file input's API) to construct an array of files every time I need to send multiple files to a Mutation, this way Relay will handle it for me, I just need to send FileList or File object.
@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact [email protected] if you have any questions.

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@leebyron
Copy link
Contributor

leebyron commented Sep 7, 2017

I'm so sorry your PR has sat here this long. Unfortunately it does not merge well anymore and we're attempting to focus on Relay Modern going forward.

I'm going to close this PR, however if this is still important to you please rebase it and reopen

@leebyron leebyron closed this Sep 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants