test: Add InputGenerator for TimestampWithTimeZone #12481
+208
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinwilfong
requested review from
assignUser and
majetideepak
as code owners
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D70362561 |
✅ Deploy Preview for meta-velox canceled.
|
kevinwilfong
force-pushed
the
export-D70362561
branch
from
cc4c78d to
99978b2
Compare
kevinwilfong
pushed a commit
to kevinwilfong/velox
that referenced
this pull request
Feb 28, 2025
…#12481) Summary: This diff adds an implementation of AbstractInputGenerator for the TimestampWithTimeZone type. It uses a random int64_t for the number of milliseconds (there may be overflow since we only have 52 bits for the milliseconds but that doesn't matter since it's random anyway) and selects a random time zone ID from a list of valid time zone IDs provided by TimeZoneMap. Differential Revision: D70362561
|
This pull request was exported from Phabricator. Differential Revision: D70362561 |
assignUser
reviewed
Feb 28, 2025
Comment on lines
+14
to
+17
| velox_add_library(velox_presto_types_fuzzer_utils | ||
| TimestampWithTimeZoneInputGenerator.cpp) | ||
|
|
||
| velox_link_libraries( |
There was a problem hiding this comment.
Suggested change
| velox_add_library(velox_presto_types_fuzzer_utils | |
| TimestampWithTimeZoneInputGenerator.cpp) | |
| velox_link_libraries( | |
| add_library(velox_presto_types_fuzzer_utils | |
| TimestampWithTimeZoneInputGenerator.cpp) | |
| target_link_libraries( |
A fuzzer util library doesn't need to be part of the main libvelox.
There was a problem hiding this comment.
I tried to, but (correct me if I'm wrong) since the AbstractInputGenerator is part of the CustomTypeFactories, TimestampWithTimeZoneRegistration.cpp needs to link against TimestampWithTimeZoneInputGenerator.h in order to construct the TimestampWithTimeZoneInputGenerator, so if it's not included in the main libvelox we run into linker errors. Similarly velox/common/fuzzer is included in the main libvelox and it contains ConstrainedGenerators.h which is just a bunch of fuzzers (AbstractInputGenerators).
kevinwilfong
force-pushed
the
export-D70362561
branch
from
99978b2 to
697a430
Compare
kevinwilfong
pushed a commit
to kevinwilfong/velox
that referenced
this pull request
Feb 28, 2025
…#12481) Summary: This diff adds an implementation of AbstractInputGenerator for the TimestampWithTimeZone type. It uses a random int64_t for the number of milliseconds (there may be overflow since we only have 52 bits for the milliseconds but that doesn't matter since it's random anyway) and selects a random time zone ID from a list of valid time zone IDs provided by TimeZoneMap. Differential Revision: D70362561
|
This pull request was exported from Phabricator. Differential Revision: D70362561 |
kevinwilfong
force-pushed
the
export-D70362561
branch
from
697a430 to
06250b5
Compare
kevinwilfong
pushed a commit
to kevinwilfong/velox
that referenced
this pull request
Feb 28, 2025
…#12481) Summary: This diff adds an implementation of AbstractInputGenerator for the TimestampWithTimeZone type. It uses a random int64_t for the number of milliseconds (there may be overflow since we only have 52 bits for the milliseconds but that doesn't matter since it's random anyway) and selects a random time zone ID from a list of valid time zone IDs provided by TimeZoneMap. Differential Revision: D70362561
|
This pull request was exported from Phabricator. Differential Revision: D70362561 |
kevinwilfong
pushed a commit
to kevinwilfong/velox
that referenced
this pull request
Feb 28, 2025
…#12481) Summary: This diff adds an implementation of AbstractInputGenerator for the TimestampWithTimeZone type. It uses a random int64_t for the number of milliseconds (there may be overflow since we only have 52 bits for the milliseconds but that doesn't matter since it's random anyway) and selects a random time zone ID from a list of valid time zone IDs provided by TimeZoneMap. Differential Revision: D70362561
kevinwilfong
force-pushed
the
export-D70362561
branch
from
06250b5 to
85a4e08
Compare
|
This pull request was exported from Phabricator. Differential Revision: D70362561 |
…#12481) Summary: This diff adds an implementation of AbstractInputGenerator for the TimestampWithTimeZone type. It uses a random int64_t for the number of milliseconds (there may be overflow since we only have 52 bits for the milliseconds but that doesn't matter since it's random anyway) and selects a random time zone ID from a list of valid time zone IDs provided by TimeZoneMap. Differential Revision: D70362561
kevinwilfong
force-pushed
the
export-D70362561
branch
from
85a4e08 to
ccfae3e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D70362561 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff adds an implementation of AbstractInputGenerator for the TimestampWithTimeZone
type. It uses a random int64_t for the number of milliseconds (there may be overflow since we
only have 52 bits for the milliseconds but that doesn't matter since it's random anyway) and
selects a random time zone ID from a list of valid time zone IDs provided by TimeZoneMap.
Differential Revision: D70362561