fix(function): Fix getTimestamp to parse fractional seconds correctly for Spark #12491
+17
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@rui-mo Could you help to take a look? |
✅ Deploy Preview for meta-velox canceled.
|
NEUpanning
changed the title
getTimestamp function for proper parsing fractional Seconds
NEUpanning
changed the title
NEUpanning
changed the title
rui-mo
reviewed
Mar 3, 2025
rui-mo
changed the title
rui-mo
reviewed
Mar 3, 2025
| // Returns null for invalid datetime format when legacy date formatter is | ||
| // used. | ||
| enableLegacyFormatter(); |
There was a problem hiding this comment.
nit: why do we need this change?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
getTimestampfunction, the fractional seconds of "1970-01-01 00:00:00.2"should be parsed as 2 milliseconds instead of 200 milliseconds to be consistent
with Spark.
Part of: #10354
Fixes: gluten issue