Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: Extend cast tests in the expression fuzzer #12492

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rui-mo
Copy link
Collaborator

@rui-mo rui-mo commented Feb 28, 2025

This PR enables tests for from-decimal and to-decimal conversions in the Presto and Spark expression fuzzer. Tests for cast(real/double as timestamp) is enabled for Spark expression fuzzer. Two issues on the cast(varchar as decimal) were fixed:

  1. Returns error status when the exponent part is empty.
  2. Status::UserError internally uses fmt::vformat which throws below exception when the string contains placeholder { or }. This PR removes the details from error message.

    uncaught exception of type fmt::v10::format_error: unmatched '}' in format string

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 28, 2025
Copy link

netlify bot commented Feb 28, 2025

Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit dc7c3d7
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/67c1da0827808b00082cc48e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants