refactor: Remove tiny range from StreamArena #12506
Open
+13
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
Summary: tinyRanges_ vector with std::string allocates exccessive amount of memory when large amount of queries with ultra wide row run in the system. Remove the structure and use the allocations_ structure to accommodate scattered tiny ranges. Reviewed By: xiaoxmeng Differential Revision: D70272119
|
This pull request was exported from Phabricator. Differential Revision: D70272119 |
|
This pull request was exported from Phabricator. Differential Revision: D70272119 |
tanjialiang
force-pushed
the
export-D70272119
branch
from
ecaead8 to
2fae462
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: tinyRanges_ vector with std::string allocates exccessive amount of memory when large amount of queries with ultra wide row run in the system. Remove the structure and use the allocations_ structure to accommodate scattered tiny ranges.
Reviewed By: xiaoxmeng
Differential Revision: D70272119