Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add is_json_scalar Presto Json function #2291

Closed
wants to merge 2 commits into from
Closed

Add is_json_scalar Presto Json function #2291

wants to merge 2 commits into from

Conversation

pramodsatya
Copy link
Collaborator

@pramodsatya pramodsatya commented Aug 14, 2022 •
edited
Loading

Adds Json function is_json_scalar to determine if the Json object represents a scalar.

@pramodsatya pramodsatya marked this pull request as draft August 14, 2022 23:51
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 14, 2022
@Yuhta Yuhta requested a review from kagamiori August 15, 2022 13:32
@pramodsatya pramodsatya changed the title Add Json functions Add is_json_scalar Presto Json function Aug 15, 2022
kagamiori
kagamiori reviewed Aug 15, 2022
View reviewed changes
Copy link
Contributor

@kagamiori kagamiori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Pramod, Thank you for adding this Json function! It looks good to me overall. I just left a few comments.

@majetideepak majetideepak marked this pull request as ready for review August 15, 2022 18:41
@kagamiori
Copy link
Contributor

Thank you, Pramod. Looks good to me. I'm going to import this PR and will keep you updated if any further change is needed.

aditi-pandit
aditi-pandit reviewed Aug 15, 2022
View reviewed changes
Copy link
Collaborator

@aditi-pandit aditi-pandit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Pramod. This is looking good. Few nits.

@facebook-github-bot
Copy link
Contributor

@kagamiori has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@pramodsatya pramodsatya mentioned this pull request Aug 15, 2022
Open
@pramodsatya pramodsatya deleted the json_func branch August 16, 2022 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kagamiori kagamiori kagamiori left review comments

@aditi-pandit aditi-pandit aditi-pandit approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pramodsatya @kagamiori @facebook-github-bot @aditi-pandit