revert bug fix for args parameter in completer functions, this will b…

…e included in a separate PR. Also update tutorial 9 to show all supported parameters may be passed

docs/tutorial/options-autocompletion.md

@@ -372,7 +372,7 @@ But it's probably useful only in very advanced use cases.
 
 ## Getting the Context and the raw *CLI parameters*
 
-Of course, you can declare everything if you need it, the context, the raw *CLI parameters*, and the incomplete `str`:
+Of course, you can declare everything if you need it, the context, the raw *CLI parameters*, the Parameter and the incomplete `str`:
 
 {* docs_src/options_autocompletion/tutorial009_an.py hl[16] *}
 

docs_src/options_autocompletion/tutorial009.py

@@ -13,7 +13,10 @@
 err_console = Console(stderr=True)
 
 
-def complete_name(ctx: typer.Context, param: Parameter, incomplete: str):
+def complete_name(
+    ctx: typer.Context, args: List[str], param: Parameter, incomplete: str
+):
+    err_console.print(f"{args}")
     names = ctx.params.get(param.name) or []
     for name, help_text in valid_completion_items:
         if name.startswith(incomplete) and name not in names:

docs_src/options_autocompletion/tutorial009_an.py

@@ -14,7 +14,10 @@
 err_console = Console(stderr=True)
 
 
-def complete_name(ctx: typer.Context, param: Parameter, incomplete: str):
+def complete_name(
+    ctx: typer.Context, args: List[str], param: Parameter, incomplete: str
+):
+    err_console.print(f"{args}")
     names = ctx.params.get(param.name) or []
     for name, help_text in valid_completion_items:
         if name.startswith(incomplete) and name not in names:

tests/test_others.py

@@ -176,7 +176,7 @@ def test_completion_untyped_parameters():
         },
     )
     assert "info name is: completion_no_types.py" in result.stderr
-    assert "args is: ['--name', 'Sebastian', '--name']" in result.stderr
+    assert "args is: []" in result.stderr
     assert "param is: name" in result.stderr
     assert "incomplete is: Ca" in result.stderr
     assert '"Camila":"The reader of books."' in result.stdout
@@ -203,7 +203,7 @@ def test_completion_untyped_parameters_different_order_correct_names():
         },
     )
     assert "info name is: completion_no_types_order.py" in result.stderr
-    assert "args is: ['--name', 'Sebastian', '--name']" in result.stderr
+    assert "args is: []" in result.stderr
     assert "param is: name" in result.stderr
     assert "incomplete is: Ca" in result.stderr
     assert '"Camila":"The reader of books."' in result.stdout

tests/test_tutorial/test_options_autocompletion/test_tutorial008.py

@@ -23,7 +23,7 @@ def test_completion():
     assert '"Camila":"The reader of books."' in result.stdout
     assert '"Carlos":"The writer of scripts."' in result.stdout
     assert '"Sebastian":"The type hints guy."' in result.stdout
-    assert "--name" in result.stderr
+    assert "[]" in result.stderr
 
 
 def test_1():

tests/test_tutorial/test_options_autocompletion/test_tutorial008_an.py

@@ -23,7 +23,7 @@ def test_completion():
     assert '"Camila":"The reader of books."' in result.stdout
     assert '"Carlos":"The writer of scripts."' in result.stdout
     assert '"Sebastian":"The type hints guy."' in result.stdout
-    assert "--name" in result.stderr
+    assert "[]" in result.stderr
 
 
 def test_1():

tests/test_tutorial/test_options_autocompletion/test_tutorial009.py

@@ -23,6 +23,7 @@ def test_completion():
     assert '"Camila":"The reader of books."' in result.stdout
     assert '"Carlos":"The writer of scripts."' in result.stdout
     assert '"Sebastian":"The type hints guy."' not in result.stdout
+    assert "[]" in result.stderr
 
 
 def test_1():

tests/test_tutorial/test_options_autocompletion/test_tutorial009_an.py

@@ -23,6 +23,7 @@ def test_completion():
     assert '"Camila":"The reader of books."' in result.stdout
     assert '"Carlos":"The writer of scripts."' in result.stdout
     assert '"Sebastian":"The type hints guy."' not in result.stdout
+    assert "[]" in result.stderr
 
 
 def test_1():

typer/_completion_classes.py

@@ -42,9 +42,6 @@ def get_completion_args(self) -> Tuple[List[str], str]:
         except IndexError:
             incomplete = ""
 
-        obj = self.ctx_args.setdefault("obj", {})
-        if isinstance(obj, dict):
-            obj.setdefault("args", args)
         return args, incomplete
 
     def format_completion(self, item: click.shell_completion.CompletionItem) -> str:
@@ -80,11 +77,6 @@ def get_completion_args(self) -> Tuple[List[str], str]:
             args = args[:-1]
         else:
             incomplete = ""
-
-        obj = self.ctx_args.setdefault("obj", {})
-        if isinstance(obj, dict):
-            obj.setdefault("args", args)
-
         return args, incomplete
 
     def format_completion(self, item: click.shell_completion.CompletionItem) -> str:
@@ -136,11 +128,6 @@ def get_completion_args(self) -> Tuple[List[str], str]:
             args = args[:-1]
         else:
             incomplete = ""
-
-        obj = self.ctx_args.setdefault("obj", {})
-        if isinstance(obj, dict):
-            obj.setdefault("args", args)
-
         return args, incomplete
 
     def format_completion(self, item: click.shell_completion.CompletionItem) -> str:
@@ -190,11 +177,6 @@ def get_completion_args(self) -> Tuple[List[str], str]:
         incomplete = os.getenv("_TYPER_COMPLETE_WORD_TO_COMPLETE", "")
         cwords = click.parser.split_arg_string(completion_args)
         args = cwords[1:-1] if incomplete else cwords[1:]
-
-        obj = self.ctx_args.setdefault("obj", {})
-        if isinstance(obj, dict):
-            obj.setdefault("args", args)
-
         return args, incomplete
 
     def format_completion(self, item: click.shell_completion.CompletionItem) -> str:

typer/core.py

@@ -84,7 +84,7 @@ def compat_autocompletion(
 
             out = []
 
-            for c in autocompletion(ctx, param, incomplete):
+            for c in autocompletion(ctx, [], param, incomplete):
                 if isinstance(c, tuple):
                     use_completion = CompletionItem(c[0], help=c[1])
                 elif isinstance(c, CompletionItem):

typer/main.py

@@ -1062,14 +1062,16 @@ def get_param_completion(
         )
 
     def wrapper(
-        ctx: click.Context, param: click.core.Parameter, incomplete: Optional[str]
+        ctx: click.Context,
+        args: List[str],
+        param: click.core.Parameter,
+        incomplete: Optional[str],
     ) -> Any:
         use_params: Dict[str, Any] = {}
         if ctx_name:
             use_params[ctx_name] = ctx
         if args_name:
-            obj = ctx.obj or {}
-            use_params[args_name] = obj.get("args", []) if isinstance(obj, dict) else []
+            use_params[args_name] = args
         if param_name:
             use_params[param_name] = param
         if incomplete_name: