Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Add support for multiple logo sources with random selection in --logo option #1426

Closed
jongwoo328 opened this issue Dec 4, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@jongwoo328
Copy link

Wanted features:

I'm using the --logo option with the path to the image.
Currently, it seems that only a single source can be specified in that option.
It would be nice to be able to take multiple logo sources and show one logo at random from them.
Something like this.
It could probably look something like this

  • --logo path1 --logo path2
  • --logo path1,path2

Or any other way!

And if this feature is added, I think we could also accept a string array in the schema for logo.

Motivation:

While it's possible to work around this limitation using shell scripts to randomize the source, having this feature built directly into the CLI would enhance usability and make the tool more user-friendly.

This feature would not only simplify workflows for advanced users but also enable casual users to achieve the same result without needing additional scripting knowledge.

Thank you for creating such a great tool!

@jongwoo328 jongwoo328 added the enhancement New feature or request label Dec 4, 2024
@CarterLi
Copy link
Member

CarterLi commented Dec 5, 2024

I don't like this idea. I don't think it's worth the effort.

This feature would not only simplify workflows for advanced users but also enable casual users to achieve the same result without needing additional scripting knowledge.

Comparing fastfetch --logo ~/Desktop/1.png --logo ~/Desktop/2.png --logo ~/Desktop/3.png --logo ~/Desktop/4.png with fastfetch --logo $(shuf -n1 -e ~/Desktop/*.png), I don't think it's considered simplifying. I don't think writing $(shuf -n1 -e ~/Desktop/*.png) requires much additional scripting knowledge.

@CarterLi CarterLi closed this as not planned Won't fix, can't repro, duplicate, stale Dec 5, 2024
@CarterLi
Copy link
Member

CarterLi commented Dec 5, 2024

Okey, I desided to simplify it furthur. If the logo source path (with the syntax of shell expansion) matches multiple files, fastfetch will randomly select one. For example:

  1. fastfetch --logo '/path/to/image*.png'
  2. fastfetch --logo '{/path/to/image1.png,/path/to/image2.png,/path/to/image3.png}' noting the braces

@jongwoo328
Copy link
Author

Thank you for adding feature!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants