-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[match] Include visionOS devices in provisioning profiles #21871
[match] Include visionOS devices in provisioning profiles #21871
Conversation
@rogerluan @lacostej Could you please take a look at this PR? I'd like to get it merged before the next release. (When is the next release?) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
One thing I wonder is that if I understand correctly, Apple has renamed xros into visionos at the last minute.
We just introduced the public parameter for pilot in #21841, and I wonder if we should have named it visionos
instead.
I think they didn't decide on the naming yet, that's why I went with both options. Actually if you unpack a provisioning profile, the platform part looks like this:
IMHO the most sustainable way would be supporting both until Apple decides on one or the other. (However my hunch is that both will stay in different circumstances) P.s. If you could merge it, I would be grateful. |
Could someone please merge this? @lacostej @rogerluan |
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validci/circleci
builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)Motivation and Context
See #21860 for more context.
Description
Added
APPLE_VISION_PRO
to theDeviceClass
enum in order to include Vision Pro devices in iOS provisioning profiles.Also added
VISION_OS
to SpaceShip to support the platform in AppStore connect.Testing Steps
Generated new provisioning profiles and validated that the devices are present in the iOS provisioning profiles.
Did it with the following steps:
This should return successfully if the device is present in the profile.