-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add example to calculate the global gravity disturbance #102
Conversation
💖 Thank you for opening your first pull request in this repository! 💖 A few things to keep in mind:
⭐ No matter what, we are really grateful that you put in the effort to do this! ⭐ |
@leouieda and @santisoler, Let me know that do you think about this example. In addition, I have a problem when I try to complete the documentation. It also happens with the CI. |
@aguspesce I'll have a look at the text later but for now upgrading PyGMT and making sure it has the right GMT version will help. These two need to be pinned together. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @aguspesce! Just a small suggestion on the colormap and a fix on the data height.
A final step would be to add this to the toctree
in the index file so it shows up in the menu.
Let me know when you're satisfied so I can merge 🙂
Co-authored-by: Leonardo Uieda <[email protected]>
Co-authored-by: Leonardo Uieda <[email protected]>
Co-authored-by: Leonardo Uieda <[email protected]>
Co-authored-by: Leonardo Uieda <[email protected]>
@leouieda, the problem to build the documentation persists. This happens to me on my pc and on the CI. |
Ah that's entirely my fault. This would never work because the Boule docs were being built with pip instead of conda... I'll try to get a fix for that in soon (or if you're up for it, be my guest 🙂). |
@aguspesce alright, I pushed some commits that enable the conda-based build of the docs. Everything passes and looks good to me. If you're happy with this, then please let me know and remove the "WIP" from the title and I'll merge this in. Thanks for doing this! |
@leouieda thank you for your help, I didn't have time to see how to fix the documentation. |
I like it 🙂 |
Thanks @aguspesce for this PR! Feel free to add youself to the |
Create an example to calculate the global gravity disturbance using Boule, Esaio and pyGMT to plot.
This idea start in fatiando/ensaio#35
Fix #101