Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests normal gravity against Somigliana equation #51

Merged
merged 4 commits into from
Jul 30, 2020
Merged

Conversation

santisoler
Copy link
Member

@santisoler santisoler commented Jul 29, 2020

Add tests functions to compare ellipsoids' normal gravity on their surface against the Somigliana equation.

Reminders:

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst and the base __init__.py file for the package.
  • Write detailed docstrings for all functions/classes/methods. It often helps to design better code if you write the docstrings first.
  • If adding new functionality, add an example to the docstring, gallery, and/or tutorials.
  • Add your full name, affiliation, and ORCID (optional) to the AUTHORS.md file (if you haven't already) in case you'd like to be listed as an author on the Zenodo archive of the next release.

santisoler and others added 2 commits July 29, 2020 12:10
Since it's shared between the ellipsoid and sphere tests, best to keep
it in a separate file. Run the tests on more latitudes (every 1 degree).
@leouieda
Copy link
Member

@santisoler I made a few changes here: mostly moved the function to a boule/tests/utils.py module and made some adjustments to the function (calculating sin and cos only once).

@leouieda
Copy link
Member

We could remove the sphere test from this branch so we can merge it with tests passing. Then we can implement it in #52 so that we're confident that we can fix the sphere gravity. What do you think?

@santisoler
Copy link
Member Author

We could remove the sphere test from this branch so we can merge it with tests passing. Then we can implement it in #52 so that we're confident that we can fix the sphere gravity. What do you think?

I agree. I will move the Somigliana test on the sphere to #52.

Thanks for the modifications, they are way better than what I drafted yesterday.

Normal gravity for a Sphere is currently wrong, so the test against
Somigliana equation will fail.
We are removing the test on this branch, but it will be added on the
branch that fixes the normal gravity error.
@santisoler santisoler changed the title WIP Tests normal gravity against Somigliana equation Tests normal gravity against Somigliana equation Jul 30, 2020
@leouieda
Copy link
Member

👍🏽 feel free to merge whenever you're ready

@santisoler santisoler merged commit 7afacbf into master Jul 30, 2020
@santisoler santisoler deleted the somigliana-test branch July 30, 2020 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants