Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tutorial for geodetic_to_geocentric transformation #84

Merged
merged 10 commits into from
Oct 11, 2021

Conversation

LL-Geo
Copy link
Member

@LL-Geo LL-Geo commented Aug 12, 2021

Add tutorials for Converting geodetic latitude and height into geocentric latitude and radius

I feel it's better to tell the coordinate and the ellipsoid height first, then go to the gravity disturbance

Reminders:

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst and the base __init__.py file for the package.
  • Write detailed docstrings for all functions/classes/methods. It often helps to design better code if you write the docstrings first.
  • If adding new functionality, add an example to the docstring, gallery, and/or tutorials.
  • Add your full name, affiliation, and ORCID (optional) to the AUTHORS.md file (if you haven't already) in case you'd like to be listed as an author on the Zenodo archive of the next release.

Add tutorials for Converting geodetic latitude and height into geocentric latitude and radius

I feel it's better to tell the coordinate and the ellipsoid height first, then go to the gravity disturbance
@welcome
Copy link

welcome bot commented Aug 12, 2021

💖 Thanks for opening your first pull request! 💖

Please make sure you read the following:

  • Authorship Guidelines: Our rules for giving you credit for your contributions, including authorship on publications and Zenodo archives.
  • Contributing Guide: What the review process is like and our infrastructure for testing and documentation.
  • Code of Conduct: How we expect people to interact in our projects.

A few things to keep in mind:

  • Remember to run make format to make sure your code follows our style guide.
  • If you need help writing tests, take a look at the existing ones for inspiration. If you don't know where to start, let us know and we'll walk you through it.
  • All new features should be documented. It helps to write the docstrings for your functions/classes before writing the code. This will help you think about your code design and results in better code.
  • No matter what, we are really grateful that you put in the effort to do this! ⭐

@LL-Geo LL-Geo changed the title Add geodetic_to_geocentric transformation Add tutorial for geodetic_to_geocentric transformation Aug 13, 2021
@leouieda
Copy link
Member

leouieda commented Oct 1, 2021

@LL-Geo thanks for this! I'll try have a look at it as soon as possible.

Copy link
Member

@leouieda leouieda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LL-Geo great stuff! Left a few suggestions to make sure the website builds correctly. The tutorial itself is really good 💯

You can commit the suggestions directly through GitHub (there should be a "Commit suggestion" button next to each). Once you're done, please give me a ping and I'm happy to merge this ❤️

Please also add yourself to the AUTHORS.md file if you'd like. Either in this PR or in a new PR later would be fine. Whatever works best for you.

@leouieda
Copy link
Member

leouieda commented Oct 4, 2021

I like the figure! Did you make it youself?

@LL-Geo
Copy link
Member Author

LL-Geo commented Oct 5, 2021

I like the figure! Did you make it youself?

Haha. Yepp. Find a new hobby for making figures 😆

@LL-Geo
Copy link
Member Author

LL-Geo commented Oct 5, 2021

@LL-Geo great stuff! Left a few suggestions to make sure the website builds correctly. The tutorial itself is really good 💯

You can commit the suggestions directly through GitHub (there should be a "Commit suggestion" button next to each). Once you're done, please give me a ping and I'm happy to merge this ❤️

Please also add yourself to the AUTHORS.md file if you'd like. Either in this PR or in a new PR later would be fine. Whatever works best for you.

All done! Haha. Thanks for all the comments and suggestions! 😉

@leouieda leouieda merged commit 6cd180e into fatiando:master Oct 11, 2021
@welcome
Copy link

welcome bot commented Oct 11, 2021

🎉🎉🎉 Congrats on merging your first pull request and welcome to the team! 🎉🎉🎉

If you would like to be added as a author on the Zenodo archive of the next release, make sure that you have added your full name, affiliation, and ORCID (optional) to the AUTHORS.md file of this repository.

We hope that this was a good experience for you. Let us know if there is any way that the contributing process could be improved.

@leouieda
Copy link
Member

🎉 Congrats on the first PR, @LL-Geo! Hopefully the first of many 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants