-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for Python 2.7 #100
Conversation
💖 Thanks for opening this pull request! 💖 Please make sure you read our contributing guidelines and abide by our code of conduct. A few things to keep in mind:
|
👋 @hugovk thank you for the contribution!
This would be done after the release only, so no need to worry about that now. |
@@ -3,9 +3,6 @@ | |||
# We use miniconda for Python so don't need any Python specific tools | |||
language: generic | |||
|
|||
# Use the container builds so we don't need sudo priviledges | |||
sudo: false | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! Made a few small wording changes. The CI failures are being caused by wrong sphinx versions in 3.5 builds. I'll try to fix that in #101 and then we can merge this 👍
Co-Authored-By: Leonardo Uieda <[email protected]>
Alright! Nice to see all checks green 👍 I'll merge this in shortly. Just need to verify that we can drop 2.7 on master right now. |
🎉🎉🎉 Congrats on merging your first pull request and welcome to the team! 🎉🎉🎉 Please open a new pull request to add yourself to the |
@hugovk thank you for your contribution to Pooch! 🎊 🥂 We're always looking for feedback on the contributing process so any inputs would be very welcome. Feel free to add yourself to the |
For PR 💯 fatiando#100
For PR 💯 fatiando#100
Thanks, added! The contributing process was smooth, there was a clear checklist in the PR template, and plenty of extra info in the contributing guidelines. I only skim-read those as I was removing/refactoring, but looks like there's good info there for creating new features. |
Thanks for the feedback! And hope to have you involved in the future 🥇 |
Python 2.7 reaches EOL on 2020-01-01 and many projects are dropping support for it.
Fixes #99.
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.TODO from #99:
I'm not sure when to do this.