Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Python 2.7 #100

Merged
merged 8 commits into from
Oct 22, 2019
Merged

Drop support for Python 2.7 #100

merged 8 commits into from
Oct 22, 2019

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Oct 6, 2019

Python 2.7 reaches EOL on 2020-01-01 and many projects are dropping support for it.

Fixes #99.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • [n/a] Add tests for new features or tests that would have caught the bug that you're fixing.
  • [n/a] Add new public functions/methods/classes to doc/api/index.rst.
  • [n/a] Write detailed docstrings for all functions/methods.
  • [n/a] If adding new functionality, add an example to the docstring, gallery, and/or tutorials.

TODO from #99:

  • Edit the conda-forge recipe to build noarch since we no longer need different dependencies depending on Python version.

I'm not sure when to do this.

@welcome
Copy link

welcome bot commented Oct 6, 2019

💖 Thanks for opening this pull request! 💖

Please make sure you read our contributing guidelines and abide by our code of conduct.

A few things to keep in mind:

  • Remember to run make format to make sure your code follows our style guide.
  • If you need help writing tests, take a look at the existing ones for inspiration. If you don't know where to start, let us know and we'll walk you through it.
  • All new features should be documented. It helps to write the docstrings for your functions/classes before writing the code. This will help you think about your code design and results in better code.
  • No matter what, we are really grateful that you put in the effort to do this! 🎉

@hugovk hugovk mentioned this pull request Oct 6, 2019
@leouieda
Copy link
Member

👋 @hugovk thank you for the contribution!

Edit the conda-forge recipe to build noarch since we no longer need different dependencies depending on Python version.

This would be done after the release only, so no need to worry about that now.

@@ -3,9 +3,6 @@
# We use miniconda for Python so don't need any Python specific tools
language: generic

# Use the container builds so we don't need sudo priviledges
sudo: false

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

Copy link
Member

@leouieda leouieda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Made a few small wording changes. The CI failures are being caused by wrong sphinx versions in 3.5 builds. I'll try to fix that in #101 and then we can merge this 👍

@leouieda
Copy link
Member

Alright! Nice to see all checks green 👍 I'll merge this in shortly. Just need to verify that we can drop 2.7 on master right now.

@leouieda leouieda merged commit 99a732f into fatiando:master Oct 22, 2019
@welcome
Copy link

welcome bot commented Oct 22, 2019

🎉🎉🎉 Congrats on merging your first pull request and welcome to the team! 🎉🎉🎉

Please open a new pull request to add yourself to the AUTHORS.md file. We hope that this was a good experience for you. Let us know if there is any way that the contributing process could be improved.

@leouieda
Copy link
Member

@hugovk thank you for your contribution to Pooch! 🎊 🥂 We're always looking for feedback on the contributing process so any inputs would be very welcome. Feel free to add yourself to the AUTHORS.md file (if you wish).

@hugovk hugovk deleted the rm-2.7 branch October 22, 2019 09:34
hugovk added a commit to hugovk/pooch that referenced this pull request Oct 22, 2019
hugovk added a commit to hugovk/pooch that referenced this pull request Oct 22, 2019
@hugovk
Copy link
Member Author

hugovk commented Oct 22, 2019

Thanks, added!

The contributing process was smooth, there was a clear checklist in the PR template, and plenty of extra info in the contributing guidelines. I only skim-read those as I was removing/refactoring, but looks like there's good info there for creating new features.

@leouieda
Copy link
Member

Thanks for the feedback! And hope to have you involved in the future 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop support for Python 2.7
2 participants