Better handling external capstone #49
Conversation
If you want to build it against capstone outside of standard prefix.
| @@ -41,7 +45,7 @@ add_custom_command(OUTPUT ${pythonbindingsfile} | |||
| COMMAND "${CMAKE_C_COMPILER}" -E ${LLVM_DEFINITIONS} -isystem ${LLVM_INCLUDE_DIRS} "${LLVM_INCLUDE_DIRS}/llvm-c/Core.h" | python "${CMAKE_SOURCE_DIR}/fcd/python/bindings.py" > ${pythonbindingsfile}) | |||
|
|
|||
| ### header search paths file ### | |||
| execute_process(COMMAND "${CMAKE_CXX_COMPILER}" -E -x c++ -v /dev/null OUTPUT_VARIABLE dummy ERROR_VARIABLE defaultHeaderSearchPathList) | |||
There was a problem hiding this comment.
-std=gnu++14 is not necessary, this command is preprocessing /dev/null to get the default include path from the stderr output. In fact, it almost certainly should be invoking ${CMAKE_C_COMPILER}, because right now it gets the C++ include path and fcd wouldn't know what to do with it.
|
The failure is just Travis being Travis on macOS. Are we happy adding I'm not very knowledgeable about CMake, so I'd like to wait until @Trass3r gets a chance to look at it (or affirmatively declines to). |
|
I think there is a better way. Will push better version bit later. |
|
An import target might be a bit cleaner than manually messing with the flags. |
If you want to build it against capstone outside of standard prefix.