Fixes for RFAI filings #1826
Fixes for RFAI filings #1826
Conversation
patphongs
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #1826 +/- ##
===========================================
- Coverage 79.42% 79.39% -0.04%
===========================================
Files 45 45
Lines 3261 3261
Branches 488 488
===========================================
- Hits 2590 2589 -1
- Misses 671 672 +1
Continue to review full report at Codecov.
|
| form_type: 'F99' | ||
| form_type: ['F99','RFAI'], | ||
| //exclude all request types except for RQ-5: RFAI referencing Statement of Candidacy | ||
| request_type: ['-1','-2','-3','-4','-6','-7','-8','-9'], |
There was a problem hiding this comment.
Could we just say request_type: ['5'] here?
There was a problem hiding this comment.
Thanks @lbeaufort! Sounds like you figured it out why I had to do it this way. Let me know if you have any further questions.
| @@ -571,7 +571,10 @@ $(document).ready(function() { | |||
| query: _.extend({ | |||
| form_type: ['F3', 'F3X', 'F3P', 'F3L', 'F4', 'F5', 'F7', 'F13', 'RFAI'], | |||
| report_type: ['-24', '-48'], | |||
| sort: ['-coverage_end_date', 'report_type_full', '-beginning_image_number'] | |||
| //exclude all request types except for RQ-2: RFAI referencing Report of Receipts and Expenditures | |||
| request_type: ['-1','-3','-4','-5','-6','-7','-8','-9'], | |||
There was a problem hiding this comment.
Could we just say request_type: ['2'] here?
| form_type: ['F1'] | ||
| form_type: ['F1','RFAI'], | ||
| //exclude all request types except for RQ-1: RFAI referencing Statement of organization | ||
| request_type: ['-2','-3','-4','-5','-6','-7','-8','-9'], |
There was a problem hiding this comment.
See above - can we just filter for RQ-1's here?
| form_type: ['F1M', 'F8', 'F99', 'F12'] | ||
| form_type: ['F1M', 'F8', 'F99', 'F12','RFAI'], | ||
| //exclude all request types except for RQ-9: RFAI referencing Multicandidate status | ||
| request_type: ['-1','-2','-3','-4','-5','-6','-7','-8'], |
There was a problem hiding this comment.
Same comments above - can we just filter for RQ-9?
|
@patphongs disregard - this trips me up every time. Once I tested out I realized that specifying the request type would return only those RQ-X's and not the reports as well. Looks good so far! |
|
Great work, @patphongs! Your PR description and local testing links were very helpful. |
|
Great work on this @patphongs and thanks for the thoughtful comments @lbeaufort. |
Summary (required)
Ensuring that the following RFAIs show up in the correct tables.
Missing from candidate pages
RQ-5s - Request for Additional Information (RFAI) referencing the Statement of Candidacy. Test URL: http://localhost:8000/data/candidate/H8AR04122/?tab=about-candidate
Missing from committee pages
RQ-1 - RFAI referencing the Statement of Organization. Test URL: http://localhost:8000/data/committee/C00637983/?tab=filings
RQ-2 - RFAI referencing Report of Receipts and Expenditures. Test URL: http://localhost:8000/data/committee/C00637983/?tab=filings
RQ-9 - Multicandidate status. Test URL: http://localhost:8000/data/committee/C00659672/?tab=filings
Impacted areas of the application
List general components of the application that this PR will affect:
Screenshots
RFAIs of RQ 2 Only
RFAIs of RQ 1 Only
RFAIs of RQ 9 Only
RFAIs of RQ 5 Only