-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT MERGE] Upgrade wagtail v2.8 and django V3.0.3 #3536
Conversation
…DDLEWARE_CLASSES. Renamed it as MIDDLEWARE.
…ango 3.0. Replaced {% load staticfiles %} tag with {% load static %} in template files.
…ango 3.0. Replaced {% load staticfiles %} tag with {% load static %} in template files.
…ed. pass admin.site.urls directly to url(), without the call to include().
We should push this to feature space so we can have content team do a through test of Wagtail functionality. |
Although we do not have to, it may actually be helpful to squash migrations before |
@johnnyporkchops I second that. I would want you and @patphongs go over the changes in the PR first and approve before i push this branch to |
@@ -9,11 +9,11 @@ psycopg2==2.7.3.2 | |||
requests==2.21.0 | |||
slacker==0.8.6 | |||
whitenoise==2.0.3 | |||
wagtail==2.2.1 | |||
wagtail==2.8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pkfec I recommend upgrading to the long term support (LTS) versions of Django and Wagtail. This will ensure greater support especially for patches and fixes than a version that is not supported. Django 2.2 is LTS until 4/2022 and Wagtail 2.7 is LTS until 2/2021.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@patphongs thanks for feedback. I am going to downgrade the wagtail and django pkg to the LTS version. I will submit a new PR with the LTS version of those packages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my recommendation
Codecov Report
@@ Coverage Diff @@
## develop #3536 +/- ##
===========================================
- Coverage 74.96% 74.94% -0.02%
===========================================
Files 120 120
Lines 7377 7373 -4
Branches 642 642
===========================================
- Hits 5530 5526 -4
Misses 1847 1847
Continue to review full report at Codecov.
|
LTS versions of Wagtail v2.7 and Django v2.2.10 upgrades are being tracked in this PR #3536 Closing this PR. |
Summary (required)
Pillow is child pkg of Wagtail and the latest version of Wagtail v2.8 comes with the pillow v6.2.2. While updating wagtail, i noticed that the wagtail v2.8 is compatible with Django v3.0. So i went ahead and updated Django to latest v3.0.3.
[Med] Snyk: Denial of Service (DoS) Due (03/08/2020) #3454
[Snyk: High] SQL Injection (Due: 03/18/2020) #3529
[Snyk: High] Integer Overflow (Due: 2/22/2020) #3482
[Snyk: High] Buffer Overflow (Due: 2/22/2020) #3478
Investigate Upgrading to Django 2.2 LTS #3105
[Snyk] unlimited allocation of resources #3396
[SNYK] - Weak Password Recovery Mechanism #3422
Include a summary of proposed changes.
six
thats not required. SET_NULL on delete flagImpacted areas of the application
How to test
FEC_API_URL
to dev, stage or prod and test the API endpoints on your local server http://127.0.0.1:8000/