Skip to content
This repository has been archived by the owner on May 22, 2024. It is now read-only.

Upgrade Node and NPM to latest #540

Closed
3 tasks done
Tracked by #139
rfultz opened this issue Oct 29, 2020 · 4 comments · Fixed by #637
Closed
3 tasks done
Tracked by #139

Upgrade Node and NPM to latest #540

rfultz opened this issue Oct 29, 2020 · 4 comments · Fixed by #637
Assignees
Milestone

Comments

@rfultz
Copy link
Contributor

rfultz commented Oct 29, 2020

What we're after

Since Node 10 is coming up on its end-of-life, should we look at upgrading Node for e-regs?

(semi-) Related tickets

Completion Criteria:

  • Upgrade NODE to LTS v14.13.0
  • Upgrade NPM to LTS v7.24.0
  • Parse 2021 regs on local
@pkfec pkfec self-assigned this Sep 15, 2021
@pkfec pkfec added this to the PI 15 innovation milestone Sep 20, 2021
@pkfec pkfec changed the title Upgrade Node to latest Upgrade Node and NPM to latest Sep 20, 2021
@pkfec
Copy link
Contributor

pkfec commented Sep 20, 2021

Tried updated node/npm engine inside fec-eregs/package.json file. Ran into node incompatible issue inside regulations-site repo.
Error stack trace:


npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: '[email protected]',
npm WARN EBADENGINE   required: { node: '10.16.0' },
npm WARN EBADENGINE   current: { node: 'v14.13.0', npm: '7.24.0' }
npm WARN EBADENGINE }

Have to upgrade NODE in regulation-site repo here:
https://github.com/fecgov/regulations-site/blob/master/regulations/static/config/package.json

@pkfec pkfec removed their assignment Nov 17, 2021
@pkfec
Copy link
Contributor

pkfec commented Nov 17, 2021

Unassigned and moved #540 to backlog.
Currently working on high priority fecgov/openFEC#4988.

@pkfec
Copy link
Contributor

pkfec commented Dec 14, 2021

On eregs, 192 vulnerabilities are flagged in production environment. After upgrading Node/NPM packages, the vulnerabilities are down to 108.

Production:
found 192 vulnerabilities (13 low, 55 moderate, 111 high, 13 critical

feature/540-upgrade-node-npm branch:
found 108 vulnerabilities (6 low, 52 moderate, 44 high, 6 critical)

@pkfec
Copy link
Contributor

pkfec commented Dec 14, 2021

Tried updated node/npm engine inside fec-eregs/package.json file. Ran into node incompatible issue inside regulations-site repo. Error stack trace:


npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: '[email protected]',
npm WARN EBADENGINE   required: { node: '10.16.0' },
npm WARN EBADENGINE   current: { node: 'v14.13.0', npm: '7.24.0' }
npm WARN EBADENGINE }

Have to upgrade NODE in regulation-site repo here: https://github.com/fecgov/regulations-site/blob/master/regulations/static/config/package.json

Upgrade node/npm on regulations-site here: https://github.com/fecgov/regulations-site/blob/master/regulations/static/config/package.json#L18-L20

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants