Feature/update locust and endpoints #3698
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
lbeaufort
reviewed
Apr 16, 2019
locustfile.py
Outdated
| else: | ||
| return [] | ||
|
|
||
| # @locust.task |
There was a problem hiding this comment.
Should these be commented out?
Codecov Report
@@ Coverage Diff @@
## develop #3698 +/- ##
========================================
Coverage 88.26% 88.26%
========================================
Files 76 76
Lines 6559 6559
========================================
Hits 5789 5789
Misses 770 770Continue to review full report at Codecov.
|
lbeaufort
reviewed
May 16, 2019
| @@ -384,6 +403,14 @@ def load_schedule_a_problematic(self): | |||
| "schedules/schedule_a/", name="load_schedule_a_problematic", params=params | |||
| ) | |||
|
|
|||
| # @locust.task | |||
There was a problem hiding this comment.
@qqss88 did you want this to be commented out? I don't think locust will run this test if it's not defined as a task.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary (required)
update locust file and endpoints walk file
Include a summary of proposed changes.
How to test the changes locally
python endpoints_walk.py
note: the added endpoints walk will fail until the update is deployed.
Impacted areas of the application
List general components of the application that this PR will affect:
api testing
Related PRs
List related PRs against other branches: