Add return value 184 (#190)

* Bump deps to latest Clean up deps Add css minification on prod Enable vendor chunk * feat: add return value, closes #184
felixmosh · Dec 9, 2020 · eb47e1c · eb47e1c
1 parent 1c48270
commit eb47e1c
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 7 deletions.
diff --git a/example.js b/example.js
@@ -3,7 +3,7 @@ const { Queue: QueueMQ, Worker, QueueScheduler } = require('bullmq')
 const Queue3 = require('bull')
 const app = require('express')()
 
-const sleep = t => new Promise(resolve => setTimeout(resolve, t * 1000))
+const sleep = (t) => new Promise((resolve) => setTimeout(resolve, t * 1000))
 
 const redisOptions = {
   port: 6379,
@@ -12,8 +12,8 @@ const redisOptions = {
   tls: false,
 }
 
-const createQueue3 = name => new Queue3(name, { redis: redisOptions })
-const createQueueMQ = name => new QueueMQ(name, { connection: redisOptions })
+const createQueue3 = (name) => new Queue3(name, { redis: redisOptions })
+const createQueueMQ = (name) => new QueueMQ(name, { connection: redisOptions })
 
 const run = async () => {
   const exampleBullName = 'ExampleBull'
@@ -23,7 +23,7 @@ const run = async () => {
 
   setQueues([new BullMQAdapter(exampleBullMq)])
 
-  exampleBull.process(async job => {
+  exampleBull.process(async (job) => {
     for (let i = 0; i <= 100; i++) {
       await sleep(Math.random())
       job.progress(i)
@@ -36,12 +36,14 @@ const run = async () => {
   })
   await queueScheduler.waitUntilReady()
 
-  new Worker(exampleBullMqName, async job => {
+  new Worker(exampleBullMqName, async (job) => {
     for (let i = 0; i <= 100; i++) {
       await sleep(Math.random())
       await job.updateProgress(i)
 
       if (Math.random() * 200 < 1) throw new Error(`Random error ${i}`)
+
+      return { jobId: `This is the return value of job (${job.id})` }
     }
   })
 

diff --git a/src/@types/app.ts b/src/@types/app.ts
@@ -62,6 +62,7 @@ export interface AppJob {
   data: JobMq['data']
   name: JobMq['name']
   delay: number | undefined
+  returnValue: string | Record<string | number, any> | null
 }
 
 export interface AppQueue {

diff --git a/src/routes/queues.ts b/src/routes/queues.ts
@@ -55,6 +55,7 @@ const formatJob = (job: Job | JobMq): app.AppJob => {
     opts: jobProps.opts,
     data: jobProps.data,
     name: jobProps.name,
+    returnValue: jobProps.returnvalue,
   }
 }
 

diff --git a/src/ui/hooks/useDetailsTabs.tsx b/src/ui/hooks/useDetailsTabs.tsx
@@ -23,12 +23,18 @@ export function useDetailsTabs(currentStatus: Status) {
       selectTab: () => setSelectedTabIdx(index),
     })),
     selectedTab,
-    getTabContent: ({ data, opts, failedReason, stacktrace }: AppJob) => {
+    getTabContent: ({
+      data,
+      returnValue,
+      opts,
+      failedReason,
+      stacktrace,
+    }: AppJob) => {
       switch (selectedTab) {
         case 'Data':
           return (
             <Highlight language="json">
-              {JSON.stringify(data, null, 2)}
+              {JSON.stringify({ data, returnValue }, null, 2)}
             </Highlight>
           )
         case 'Options':