-
-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: toggle failed queues only #742
Conversation
2a87f69
to
26afc00
Compare
@tsirilson thank you for this PR, Will you be able to update your PR? |
@felixmosh Great point. What if instead of a modal, I convert the status names into clickable "buttons" that toggle the status on and off? It will also be less intrusive and won't require creating a modal for this feature only. There can also be a tooltip when hovering a status name that hints what will happen if you click it. What do you think? |
Instead of creating a setting for that. I would create a route to receive a on <Route path="/queue/by-status/:status" render={() => <QueueByStatusPageLazy />} /> It would be a copy of Also the statuses on Overview page could be turned into links, redirecting to this page. |
Sounds good to me 🙏🏼 |
@manfe Interesting approach. Direct links is something I would also prefer, the option to link to a specific job is something I find very useful since it was added. @felixmosh which do you think would benefit users the most? Same page filters or dedicated routes? |
It can be both, it is a matter of implementation. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Added a toggle to filter out non-failing queues.
Why?
When using Bull Board for production monitoring purposes, it's very useful when you want to know about failing jobs (not as a substitute for alerts).
In my case, I'm displaying it on a TV in my company's office and we have 20 different queues currently, which makes it hard to follow if any of them have failures, especially if one of the queues has a lot of successful jobs, so it's easy to miss that there's one failed job out of a thousand successful ones.
Filtering successful ones out should help us focus on the board only when we notice that there are any failing queues.