(fix, TypeScript): remove flaky fetcher test (#4226)

generators/typescript/sdk/CHANGELOG.md

@@ -5,6 +5,10 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.38.5] - 2024-08-07
+
+- Fix: Addressed fetcher unit test flakiness by using a mock fetcher
+
 ## [0.38.4] - 2024-08-04
 
 - Fix: Literal templates are generated if they are union members

generators/typescript/sdk/VERSION

@@ -1 +1 @@
-0.38.4
+0.38.5

generators/typescript/utils/commons/src/core-utilities/fetcher/FetcherImpl.ts

@@ -47,6 +47,9 @@ export class FetcherImpl extends CoreUtility implements Fetcher {
             dependencyManager.addDependency("@types/node-fetch", "2.6.9", {
                 type: DependencyType.DEV
             });
+            dependencyManager.addDependency("fetch-mock-jest", "^1.5.1", {
+                type: DependencyType.DEV
+            });
         }
     };
     public readonly Fetcher: Fetcher["Fetcher"] = {

generators/typescript/utils/core-utilities/fetcher/package.json

@@ -43,6 +43,7 @@
     "depcheck": "^1.4.6",
     "eslint": "^8.56.0",
     "express": "^4.19.2",
+    "fetch-mock-jest": "^1.5.1",
     "form-data": "4.0.0",
     "jest": "^29.7.0",
     "jest-environment-jsdom": "^29.7.0",

generators/typescript/utils/core-utilities/fetcher/src/fetcher/__test__/Fetcher.test.ts

@@ -1,28 +1,7 @@
+import fetchMock from "fetch-mock-jest";
 import { Fetcher, fetcherImpl } from "../Fetcher";
 
 describe("Test fetcherImpl", () => {
-    let mockCreateUrl: jest.Mock;
-    let mockGetBody: jest.Mock;
-    let mockGetFetchFn: jest.Mock;
-    let mockRequestWithRetries: jest.Mock;
-    let mockGetResponseBody: jest.Mock;
-
-    beforeEach(() => {
-        mockCreateUrl = jest.fn();
-        mockGetBody = jest.fn();
-        mockGetFetchFn = jest.fn();
-        mockRequestWithRetries = jest.fn();
-        mockGetResponseBody = jest.fn();
-
-        jest.mock("../Fetcher", () => ({
-            createUrl: mockCreateUrl,
-            getBody: mockGetBody,
-            getFetchFn: mockGetFetchFn,
-            requestWithRetries: mockRequestWithRetries,
-            getResponseBody: mockGetResponseBody
-        }));
-    });
-
     it("should handle successful request", async () => {
         const mockArgs: Fetcher.Args = {
             url: "https://httpbin.org/post",
@@ -33,15 +12,14 @@ describe("Test fetcherImpl", () => {
             requestType: "json"
         };
 
-        mockCreateUrl.mockReturnValue("https://test.com");
-        mockGetBody.mockResolvedValue(JSON.stringify({ data: "test" }));
-        mockGetFetchFn.mockResolvedValue(() => Promise.resolve());
-        mockRequestWithRetries.mockResolvedValue({ status: 200 });
-        mockGetResponseBody.mockResolvedValue({ result: "success" });
+        fetchMock.mock("https://httpbin.org/post", 200, {
+            response: JSON.stringify({ data: "test" })
+        });
 
         const result = await fetcherImpl(mockArgs);
         expect(result.ok).toBe(true);
-        // @ts-expect-error
-        expect(result.body.json).toEqual({ data: "test" });
+        if (result.ok) {
+            expect(result.body).toEqual({ data: "test" });
+        }
     });
 });