chore: add nuget config for csharp sdks #3621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsinghvi
reviewed
May 15, 2024
dsinghvi
reviewed
May 15, 2024
dsinghvi
reviewed
May 15, 2024
| }).replaceAll("\\{", "{"); | ||
| const ghDir = join(this.absolutePathToOutputDirectory, RelativeFilePath.of(".github/workflows")); | ||
| await mkdir(ghDir, { recursive: true }); | ||
| await writeFile(join(ghDir, RelativeFilePath.of("ci.yml")), githubWorkflow); |
There was a problem hiding this comment.
how do we make sure this only happens when the generator is in github mode?
There was a problem hiding this comment.
This is already the case!
The template has a conditional that's if the publish block is present, which is a GitHub output block
I tested it and it works well, the whole block is added or removed
Check the template evaluation a couple lines above
There was a problem hiding this comment.
Getting the config: https://github.com/fern-api/fern/pull/3621/files#diff-2e2d2dd0dc8bd56571b1e52014eab736a44e2dc8f6d0f4306c98f7ababb197daR44-R53
The template conditional: https://github.com/fern-api/fern/pull/3621/files#diff-cc3e7dbc9ed09e0f85aedca78c522a60a73836e9c33076c82968d8333c1f08cdR27-R48
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.