-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(fix, typescript): multipart form upload on Node 19+ #4056
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m/fern-api/fern into rohin/multipart-form-upload-fixes
…m/fern-api/fern into rohin/multipart-form-upload-fixes
dsinghvi
commented
Jul 16, 2024
generators/typescript/utils/core-utilities/fetcher/src/fetcher/getRequestBody.ts
Show resolved
Hide resolved
dsinghvi
commented
Jul 16, 2024
generators/typescript/utils/core-utilities/fetcher/src/fetcher/getRequestBody.ts
Outdated
Show resolved
Hide resolved
dsinghvi
commented
Jul 16, 2024
...ypescript/utils/core-utilities/fetcher/src/form-data-utils/__test__/multipart.upload.test.ts
Show resolved
Hide resolved
dsinghvi
commented
Jul 16, 2024
generators/typescript/utils/core-utilities/fetcher/src/form-data-utils/FormDataWrapper.ts
Outdated
Show resolved
Hide resolved
dsinghvi
commented
Jul 16, 2024
generators/typescript/utils/core-utilities/fetcher/src/form-data-utils/FormDataWrapper.ts
Outdated
Show resolved
Hide resolved
dsinghvi
commented
Jul 16, 2024
@@ -94,6 +94,7 @@ export declare namespace Fetcher { | |||
withCredentials: boolean; | |||
timeoutInSeconds: ts.Expression; | |||
maxRetries?: ts.Expression; | |||
requestType?: "json" | "file" | "bytes" | "other"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we remove other
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: This release comes with numerous improvements to multipart uploads:
Fetcher.ts
no longer depends on form-data and formdata-node which reducesthe size of the SDK for all consumers that are not leveraging multipart form
data uploads.
fs.ReadStream
,Blob
andFile
as inputs and handlesparsing them appropriately.
Blob
as a file parameter, the SDK now supports sending thefilename when making a request.