Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat, fastapi): introduce endpoint specific async handlers in fastapi #4188

Merged
merged 3 commits into from
Aug 2, 2024

Conversation

dsinghvi
Copy link
Member

@dsinghvi dsinghvi commented Aug 2, 2024

Feature: The FastAPI async_handlers configuration now accepts a list of string or a boolean so that users
can turn on async handlers for specific endpoints. For example, to turn on async handlers for a users.create
endpoint, use the configuration below:

- name: fernapi/fern-fastapi-server
  version: 1.1.1
  config:
    async_handlers:
      - users.create

@dsinghvi dsinghvi changed the title (feat): introduce endpoint specific async handlers in fastapi (feat, fastapi): introduce endpoint specific async handlers in fastapi Aug 2, 2024
@dsinghvi dsinghvi requested a review from armandobelardo August 2, 2024 06:27
@dsinghvi dsinghvi marked this pull request as ready for review August 2, 2024 06:27
@@ -1 +1 @@
1.1.0-rc0
1.1.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: 1.2.0? Just cause it's a feature not a fix

Copy link
Contributor

@armandobelardo armandobelardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
The endpoint list isn't the easiest to maintain as your endpoints grow and change, but not sure how else we'd do it without modifying the fern def which I know we don't want do do here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants