c#, fix: class names + namespace conflicts #4229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcb6
commented
Aug 7, 2024
| /// This reference to A should not use it's fully qualified name because it's in the same package as A. | ||
| /// </summary> | ||
| [JsonPropertyName("id")] | ||
| public required A Id { get; set; } |
There was a problem hiding this comment.
we're in the same namespace as A so we don't need to fully qualify
dcb6
commented
Aug 7, 2024
| DefaultIgnoreCondition = JsonIgnoreCondition.WhenWritingNull | ||
| }; | ||
|
|
||
| var deserializedObject = JsonSerializer.Deserialize<SeedCsharpNamespaceConflict.A.A>( |
There was a problem hiding this comment.
Fully qualified example
dsinghvi
reviewed
Aug 7, 2024
| @@ -7,7 +7,8 @@ import { GeneratorWorkspace } from "../../loadGeneratorWorkspaces"; | |||
| import { printTestCases } from "./printTestCases"; | |||
| import { TestRunner } from "./test-runner"; | |||
|
|
|||
| export const FIXTURES_TO_IGNORE = ["sever-sent-event-examples", "server-sent-event-examples"]; | |||
| export const FIXTURES_TO_IGNORE = ["server-sent-event-examples", "server-sent-events"]; | |||
| export const LANGUAGE_SPECIFIC_FIXTURE_PREFIXES = ["csharp", "go", "java", "python", "ruby", "ts"]; | |||
dsinghvi
reviewed
Aug 7, 2024
generators/csharp/codegen/src/context/AbstractCsharpGeneratorContext.ts
Outdated
Show resolved
Hide resolved
dsinghvi
reviewed
Aug 7, 2024
dsinghvi
reviewed
Aug 7, 2024
dsinghvi
approved these changes
Aug 8, 2024
dsinghvi
pushed a commit
that referenced
this pull request
Aug 9, 2024
This was referenced Sep 16, 2024
This was referenced Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C# generator changes:
Seed changes: