(feat, cli): add has-next-page property to IR
#4241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amckinney
reviewed
Aug 9, 2024
| propertyComponents: paginationPropertyComponents.step | ||
| }) | ||
| : undefined, | ||
| hasNextPage: | ||
| paginationPropertyComponents.step != null |
There was a problem hiding this comment.
This should be hasNextPage, right?
amckinney
reviewed
Aug 9, 2024
| @@ -5,6 +5,10 @@ All notable changes to this project will be documented in this file. | |||
| The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), | |||
| and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). | |||
|
|
|||
| ## [v53.5.0] - 2024-08-05 \*\* (TODO: Make required in next major) | |||
|
|
|||
| - Feature: Support a `hasOffset | |||
amckinney
reviewed
Aug 9, 2024
| if (primitiveType == null) { | ||
| return false; | ||
| } | ||
| return primitiveType === "BOOLEAN"; |
There was a problem hiding this comment.
I could see us eventually supporting string so that it can be used similar to an empty cursor token, but let's start with this for now, especially because there aren't any IR changes required.
amckinney
approved these changes
Aug 9, 2024
dsinghvi
force-pushed
the
dsinghvi/add-has-next-page-property-to-ir
branch
from
5856975 to
77fcd7c
Compare
dsinghvi
force-pushed
the
dsinghvi/add-has-next-page-property-to-ir
branch
from
2b6709d to
823dc8d
Compare
This was referenced Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a
has-next-pageproperty to IR for offset pagination. If the response from an offset paginated contains a boolean about whether or not the next page exists, then this will allow the SDK to compute if the next page exists without making an RPC call.