Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix): docs take into account global path params and now we add tests #4309

Merged
merged 3 commits into from
Aug 14, 2024

Conversation

dsinghvi
Copy link
Member

The IR-to-FDR converter now takes into account global path parameters. We also introduce tests for ir to fdr conversion + vitest migration.

@dsinghvi dsinghvi requested a review from amckinney August 14, 2024 21:07
Copy link

gitguardian bot commented Aug 14, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
13411598 Triggered Generic High Entropy Secret 836b11a packages/cli/register/src/ir-to-fdr-converter/covertAuth.ts View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@dsinghvi dsinghvi marked this pull request as ready for review August 14, 2024 21:07
@dsinghvi dsinghvi enabled auto-merge (squash) August 14, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants