Add RW BigInt64 methods #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feross
added a commit
that referenced
this pull request
Nov 4, 2020
Since Buffer now supports the BigInt methods and the code for that uses the exponentiation operator, I'm going to drop support for IE11 and Safari 9-10. Further changes I needed to make: - Use consistent shifting to floor the offset numbers, like we do for other methods - Remove all BigInt literals in favor of using a BigInt constructor – this fixes parse errors in older browsers like Safari 11 - Disable Node tests in Safari 11 and 12 since they use BigInt literal syntax This commit contains fixes for PR #267
|
Looks good. Since this PR uses the exponentiation operator, I'm going to drop support for IE11 and Safari 9-10 in order to accept it. Further changes I needed to make:
|
|
Released as 6.0.0 |
Could this mean that we could do things such as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descriptions
This PR is extension of PR #247 by @fanatid.
It addresses the issue described in #247 (comment)