Snapdeals unsealing fixes

[magik6k]

Related Issues

Depends on filecoin-project/go-state-types#191
Depends on filecoin-project/filecoin-ffi#402

(todo link relevant issues)

Proposed Changes

Additional Info

Testing:

• ITests
  • Existing itests pass
  • Test unseal on a worker with no long-term-storage, verify files cleaned up correctly
• Manual testing

Checklist

Before you mark the PR ready for review, please make sure that:

• Commits have a clear commit message.
• PR title is in the form of of <PR type>: <area>: <change being made>
  • example: fix: mempool: Introduce a cache for valid signatures
  • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
  • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
• New features have usage guidelines and / or documentation updates in
  • Lotus Documentation
  • Discussion Tutorials
• Tests exist for new functionality or change in behavior
• CI is green

[magik6k]

Blocked on FFI changes landing

Other than that I'm reasonably confident this works, or at least isn't worse than current state.

[Reiers]

Testing:

• ITests
  • Existing itests pass
  • Test unseal on a worker with no long-term-storage, verify files cleaned up correctly
• Manual testing
  • Test normal unseal
    • Works on a worker with only sealing paths
    • Unsealed file is moved to long-term storage after unsealing
    • No files are left in sealing paths after unseal is done
    • Sealed + Unsealed files are in long-term-storage
  • Test snapdeals unseal
    • Without sector-key in storage
      • Works on a worker with only sealing paths
      • Unsealed file is moved to long-term storage after unsealing
      • No files are left in sealing paths after unseal is done
      • Update + Unsealed files are in long-term-storage
    • With sector-key in storage already
      • Works on a worker with only sealing paths
      • Unsealed file is moved to long-term storage after unsealing
      • No files are left in sealing paths after unseal is done
      • Update + Unsealed files are in long-term-storage

Unsealing on a worker works flawlessly - it moves the unsealed sectors to the long term storage, deletes the leftover files on the worker. Great job !

Tested for 2 days on Snap and Regular sectors.

Only one request, is that lotus-miner sectors unseal <sector> doesn't hang.

[magik6k]

Hanging unseal command is a separate thing related to how this command works - #11133

[magik6k]

The go-state-types PR we depend on here got merged after nv21 changes, which break some integration tests without synth-porep ffi changes

Marking as blocked for now, those failing tests should resolve themselves after rebasing on synth-porep code.

[rjan90]

@magik6k Can we turn this back to unblocked now that nv21 skeleton has been merged into master?