Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: markets/dagstore: remove trace goroutine for dagstore wrapper #11191

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

nonsense
Copy link
Member

@nonsense nonsense commented Aug 21, 2023

Related Issues

Closing of trace channel improperly, results in DAGStore Closing blocking and the process doesn't exit correctly upon SIGTERM.

Note that this piece of code is not used in lotus or lotus-miner anymore and is used in boost.

Proposed Changes

Remove DAGStore tracing from within the wrapper.

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@nonsense nonsense requested a review from dirkmc August 21, 2023 15:49
@nonsense
Copy link
Member Author

goroutine 126045 [chan send, 153 minutes]:
runtime.gopark(0x5510fca?, 0x8?, 0x5?, 0x88?, 0x25?)
	/snap/go/current/src/runtime/proc.go:381 +0xd6 fp=0xc00f73d7f8 sp=0xc00f73d7d8 pc=0x7d18d6
runtime.chansend(0xc010ffc240, 0xc00f73dd38, 0x1, 0xc011c04dd0?)
	/snap/go/current/src/runtime/chan.go:259 +0x42e fp=0xc00f73d880 sp=0xc00f73d7f8 pc=0x79b80e
runtime.chansend1(0xc012461c38?, 0x2?)
	/snap/go/current/src/runtime/chan.go:145 +0x1d fp=0xc00f73d8b0 sp=0xc00f73d880 pc=0x79b3bd
github.com/filecoin-project/dagstore.(*DAGStore).control(0xc014789ce0)
	/home/admfc/go/pkg/mod/github.com/filecoin-project/[email protected]/dagstore_control.go:337 +0x1faa fp=0xc00f73dfc8 sp=0xc00f73d8b0 pc=0x257c5aa
github.com/filecoin-project/dagstore.(*DAGStore).Start.func1()
	/home/admfc/go/pkg/mod/github.com/filecoin-project/[email protected]/dagstore.go:309 +0x26 fp=0xc00f73dfe0 sp=0xc00f73dfc8 pc=0x2576626
runtime.goexit()
	/snap/go/current/src/runtime/asm_amd64.s:1598 +0x1 fp=0xc00f73dfe8 sp=0xc00f73dfe0 pc=0x8064c1
created by github.com/filecoin-project/dagstore.(*DAGStore).Start
	/home/admfc/go/pkg/mod/github.com/filecoin-project/[email protected]/dagstore.go:309 +0x7ef


goroutine 197261356 [semacquire, 1 minutes]:
runtime.gopark(0xc0000da4f0?, 0x4e94060?, 0xa0?, 0xb?, 0x0?)
	/snap/go/current/src/runtime/proc.go:381 +0xd6 fp=0xc00c717a90 sp=0xc00c717a70 pc=0x7d18d6
runtime.goparkunlock(...)
	/snap/go/current/src/runtime/proc.go:387
runtime.semacquire1(0xc014789e28, 0x0?, 0x1, 0x0, 0x60?)
	/snap/go/current/src/runtime/sema.go:160 +0x20f fp=0xc00c717af8 sp=0xc00c717a90 pc=0x7e30af
sync.runtime_Semacquire(0xc0000da4f0?)
	/snap/go/current/src/runtime/sema.go:62 +0x27 fp=0xc00c717b30 sp=0xc00c717af8 pc=0x801e87
sync.(*WaitGroup).Wait(0x0?)
	/snap/go/current/src/sync/waitgroup.go:116 +0x4b fp=0xc00c717b58 sp=0xc00c717b30 pc=0x825b6b
github.com/filecoin-project/dagstore.(*DAGStore).Close(0xc014789ce0)
	/home/admfc/go/pkg/mod/github.com/filecoin-project/[email protected]/dagstore.go:546 +0x39 fp=0xc00c717b90 sp=0xc00c717b58 pc=0x2577b39
github.com/filecoin-project/lotus/markets/dagstore.(*Wrapper).Close(0xc0103999a0)
	/home/admfc/go/pkg/mod/github.com/filecoin-project/[email protected]/markets/dagstore/wrapper.go:453 +0xaa fp=0xc00c717c40 sp=0xc00c717b90 pc=0x290168a
github.com/filecoin-project/lotus/node/modules.DAGStore.func1.2({0x4f093e0, 0x6838500})
	/home/admfc/go/pkg/mod/github.com/filecoin-project/[email protected]/node/modules/storageminer_dagstore.go:88 +0x1d fp=0xc00c717c58 sp=0xc00c717c40 pc=0x292409d
go.uber.org/fx/internal/lifecycle.(*Lifecycle).runStopHook(0xc00001fb20, {0x684ee38, 0xc000058d50}, {0xc00f1f1060, 0xc00f1f1070, {0x0, 0x0}, {0x0, 0x0}, {{0xc00d479240, ...}, ...}})
	/home/admfc/go/pkg/mod/go.uber.org/[email protected]/internal/lifecycle/lifecycle.go:341 +0x212 fp=0xc00c717d60 sp=0xc00c717c58 pc=0x1956492
go.uber.org/fx/internal/lifecycle.(*Lifecycle).Stop(0xc00001fb20, {0x684ee38, 0xc000058d50})
	/home/admfc/go/pkg/mod/go.uber.org/[email protected]/internal/lifecycle/lifecycle.go:303 +0x568 fp=0xc00c717f18 sp=0xc00c717d60 pc=0x1955d88
go.uber.org/fx.(*App).Stop.func2({0x684ee38?, 0xc000058d50?})
	/home/admfc/go/pkg/mod/go.uber.org/[email protected]/app.go:701 +0x91 fp=0xc00c717f80 sp=0xc00c717f18 pc=0x1963a51
go.uber.org/fx.withTimeout.func1()
	/home/admfc/go/pkg/mod/go.uber.org/[email protected]/app.go:782 +0x85 fp=0xc00c717fe0 sp=0xc00c717f80 pc=0x1964025
runtime.goexit()
	/snap/go/current/src/runtime/asm_amd64.s:1598 +0x1 fp=0xc00c717fe8 sp=0xc00c717fe0 pc=0x8064c1
created by go.uber.org/fx.withTimeout
	/home/admfc/go/pkg/mod/go.uber.org/[email protected]/app.go:770 +0xea

@nonsense nonsense force-pushed the nonsense/remove-trace-goroutine branch from a8f2e23 to 9028df4 Compare August 21, 2023 15:55
@nonsense nonsense changed the title remove trace goroutine for dagstore wrapper fix: markets/dagstore: remove trace goroutine for dagstore wrapper Aug 21, 2023
@nonsense nonsense marked this pull request as ready for review August 21, 2023 16:26
@nonsense nonsense requested a review from a team as a code owner August 21, 2023 16:26
@magik6k magik6k merged commit 5f5c6a0 into master Aug 22, 2023
@magik6k magik6k deleted the nonsense/remove-trace-goroutine branch August 22, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants