Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mpool: Cache actors in lite mode #11668

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Mar 1, 2024

Related Issues

Mpool startup in lite mode for some reason requests the same actor head 1000s of times (probably for each message ever sent)

Proposed Changes

Additional Info

This makes my node start in ~2 seconds instead of roughly 20min when backed by a lite node

Likely there is a better fix to the underlying issue like cleaning up messages in mpool after finality, but this is way simpler and also solves the issue.

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@magik6k magik6k requested a review from a team as a code owner March 1, 2024 12:56
@magik6k magik6k requested review from Stebalien and arajasek March 1, 2024 12:56
@magik6k magik6k force-pushed the feat/fast-lite-mpool-startup branch from fe125fa to 8615b01 Compare March 11, 2024 11:39
@magik6k magik6k force-pushed the feat/fast-lite-mpool-startup branch from c9894c9 to 8615b01 Compare March 11, 2024 19:59
@magik6k magik6k requested a review from rvagg March 11, 2024 20:33
@magik6k magik6k enabled auto-merge (squash) March 12, 2024 09:44
@magik6k magik6k merged commit c1c5deb into master Mar 12, 2024
88 checks passed
@magik6k magik6k deleted the feat/fast-lite-mpool-startup branch March 12, 2024 09:44
ribasushi pushed a commit to ribasushi/ci-abusing-lotus-fork that referenced this pull request May 11, 2024
ribasushi pushed a commit to ribasushi/ci-abusing-lotus-fork that referenced this pull request May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ☑️ Done (Archive)
Development

Successfully merging this pull request may close these issues.

2 participants