Choose Terminal Applications

[FelixZacher]

Description

• Creates a terminals.json in the "local"-AppFolder with terminal profiles (file). As default profile the "cmd"-profile is included. A second commented profile for powershell is also included. It seems the new Windows Terminal currently does not support launching in a specific directory from commandline (link).
• Includes a combobox in the settings to choose between the profiles.

UI

Light	Dark

Question

1. JSON.Net as dependency?
2. terminal.json-schema? At the moment you can specify a name, a description, the executable path, arguments and an icon, but only the name, the path and the arguments are used.

[lukeblevins]

Looks good to me. This should provide a better foundation for users to configure which terminals are used.

[SOI7]

@lampenlampen Judging from this post (https://github.com/microsoft/terminal/issues/620) it seems that now it's possible to launch Windows Terminal from a directory. The command line in the address bar is wt.exe and to enable the starting directory you need to add "startingDirectory": "." in the default profile used in Terminal. I tried this in the Win32 Explorer and works like a charme, and adding this to the terminal.json should be straghtforward (I tried this on 0.7.1 as well, the command works for opening Terminal but none of the consoles actually launches in the folder I run the command from, not even cmd)

EDIT: An upcoming update will also enable this through wt -d according to this post: https://github.com/microsoft/terminal/issues/878

[FelixZacher]

Hey, Opening in a directory is currently not supported. This feature needs some work that is currently in the 'settings-vm'-branch.

…

________________________________ Von: SOI_7 <[email protected]> Gesendet: Donnerstag, 30. Januar 2020 00:39 An: duke7553/files-uwp Cc: lampenlampen; Mention Betreff: Re: [duke7553/files-uwp] Choose Terminal Applications (#361) @lampenlampen<https://eur05.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Flampenlampen&data=02%7C01%7C%7Cd8265e157edd49a74d2008d7a51482c8%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637159379811957115&sdata=cx5Wm1cCpSKgAbD6vRUzaRq4IgaFevvAjrBPJr7JyyU%3D&reserved=0> Judging from this post (microsoft/terminal#620<url>) it seems that now it's possible to launch Windows Terminal from a directory. The command line in the address bar is wt.exe and to enable the starting directory you need to add "startingDirectory": "." in the default profile used in Terminal. I tried this in the Win32 Explorer and works like a charme, and adding this to the terminal.json should be straghtforward (I tried this on 0.7.1 as well, the command works for opening Terminal but none of the consoles actually launches in the folder I run the command from, not even cmd) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://eur05.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fduke7553%2Ffiles-uwp%2Fpull%2F361%3Femail_source%3Dnotifications%26email_token%3DAGH4KWWWRDQRNCKX4ALXBM3RAIHTZA5CNFSM4KBWATD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKJFJAI%23issuecomment-580015233&data=02%7C01%7C%7Cd8265e157edd49a74d2008d7a51482c8%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637159379811957115&sdata=ee4G%2BZx2lK5D6Q5zPdN8T%2Bqm126Pgft%2FOR8e3mO4pZo%3D&reserved=0>, or unsubscribe<https://eur05.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAGH4KWUDPR6YFJQIMLGQDQ3RAIHTZANCNFSM4KBWATDQ&data=02%7C01%7C%7Cd8265e157edd49a74d2008d7a51482c8%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637159379811967124&sdata=yZUK%2F5HlRRK6TZ%2BwhXCF0j6ecYSMYrrfE9njiMAdm70%3D&reserved=0>.

[yaira2]

@lampenlampen We ported over the work in settings-vm to v0.7.1-changes.

[FelixZacher]

@SOI7 I missunderstand you. I thought you talked about opening files in a specific directory.

I checked and I am able to open cmd in the specified directory.

I would suggest opening a bug report and I will need more information to investigate.

PS: I only checked with the default cmd profile.

[SOI7]

@SOI7 I missunderstand you. I thought you talked about opening files in a specific directory.

I checked and I am able to open cmd in the specified directory.

No, I was talking about opening the preferred terminal app (specified in Files settings) from a folder in Files. I simply bumped you because in the OP you stated "It seems the new Windows Terminal currently does not support launching in a specific directory from commandline", and now things have changed

[FelixZacher]

So i played with Windows Terminal a bit.

1. You cannot pass a path to open in Windows Terminal. So for me it seems, that Windows Terminal simply opens the workingDirectory of the process it was launched from. Therefore it works from terminals and the explorer, but i think it will not work with files, because it does not change it's workingDirectory to the folder currently displayed.
   
   Therefore we have to wait until Windows Terminal support passing a path to it.

2. On my machine I'm able to open a directory in cmd and powershell. So for this issue i suggest opening a bug report here and include your profiles.json.

PS1:
I actually tried opening Windows Terminal from files and it opens in System32. So we will have to wait for Windows Terminal to support a path argument.