Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current line highlight does not work #747

Closed
denis-sokolov opened this issue Dec 25, 2022 · 1 comment
Closed

Current line highlight does not work #747

denis-sokolov opened this issue Dec 25, 2022 · 1 comment

Comments

@denis-sokolov
Copy link
Collaborator

Since v2.14.6 the current line is not highlighted due to a bug upstream: PrismJS/prism#3552.

bart-jaskulski added a commit to bart-jaskulski/whoops that referenced this issue Apr 12, 2023
PrismJS sort of broken backward compatibility, while trying to improve
highlight resilience[^1]. Since then it is required to add
`data-line-offset` for any code, which doesn't start counting from 1,
which is pretty each time, we deal with stack frames.

This commits add silently required data attribute in HTML, bringing back
highlight feature and recovering from some fall through errors, raised
by `TypeError` in JS execution flow (i.e. switching application and full
frames tabs).

[^1]: PrismJS/prism@9a4e725

Signed-off-by: Bart Jaskulski <[email protected]>
denis-sokolov added a commit that referenced this issue Apr 12, 2023
fix(highlight): #747 Add line offset to highlight line
@denis-sokolov
Copy link
Collaborator Author

Fixed in Released in 2.15.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant