Container contract updates #4388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partial revert of #4240 where we transformed EventFilters to list of arrays. We now prefer to keep the object structure. To support path-pattern operator on event filters, we add new eventFilterPathPattern property. Also adds channel property to event trigger definition.
colerogers
requested changes
Mar 31, 2022
colerogers
approved these changes
Mar 31, 2022
inlined
reviewed
Apr 5, 2022
| @@ -48,7 +48,7 @@ export interface CallableTriggered { | |||
| callableTrigger: CallableTrigger; | |||
| } | |||
|
|
|||
| type EventFilterKey = "resource" | "topic" | "bucket" | string; | |||
| type EventFilterKey = "resource" | "topic" | "bucket" | "alerttype" | string; | |||
There was a problem hiding this comment.
I wonder if it's silly to keep this type.
| @@ -485,6 +477,9 @@ export function functionFromEndpoint(endpoint: backend.Endpoint, source: Storage | |||
| return gcfFunction; | |||
| } | |||
|
|
|||
| /** | |||
| * | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial revert of #4240 where we transformed EventFilters to list of arrays. We now prefer to keep the object structure.
To support path-pattern operator on event filters, we add new eventFilterPathPattern property. While we are at it, we also adds channel property to event trigger definition.
Note that most of the affected changes are in test files :/
Relevant SDK change: firebase/firebase-functions#1070