Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(database)!: rework as part of #6979 #7202

Merged
merged 79 commits into from
Dec 3, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
79 commits
Select commit Hold shift + click to select a range
1ac17f9
refactor(database): rename reference() to ref([String? path]) (#7045)
lesnitsky Sep 23, 2021
8ca457b
refactor(database): android refactor WIP
lesnitsky Oct 8, 2021
6777775
refactor(database): refactor android plugin
lesnitsky Oct 12, 2021
883c29c
refactor(database): fix tests and refactor dart to match java changes
lesnitsky Oct 13, 2021
f870162
refactor(database): refactor example app
lesnitsky Oct 13, 2021
16b4bae
refactor(database): refactor event channels
lesnitsky Oct 13, 2021
7e41c36
refactor(database): refactor event channels and code cleanup
lesnitsky Oct 14, 2021
f562799
fix(database): make sure configuration is performed before any usage
lesnitsky Oct 14, 2021
f6d7b20
refactor(database): improve errors
lesnitsky Oct 14, 2021
0d6295a
refactor(database): convert PlatformException to FirebaseDatabaseExce…
lesnitsky Oct 15, 2021
c2ca1f6
test(database): add more tests
lesnitsky Oct 15, 2021
2bb496c
chore: bump gradle wrapper from 5.6.4 to 7.0.2
Salakar Oct 18, 2021
219a737
refactor(database): more tests; refactor transactions
lesnitsky Oct 19, 2021
9ce5bfa
chore: minor code typos
Salakar Oct 19, 2021
495aac1
fix: remove transaction handler after transaction is completed
Salakar Oct 19, 2021
d7007fe
refactor: minor Java linting fixes
Salakar Oct 19, 2021
ceb8c07
fix(database): fix web transactions
lesnitsky Oct 20, 2021
65f9468
chore(database): fix analyzer
lesnitsky Oct 20, 2021
9819a1f
test(database): ignore unsupported tests on web
lesnitsky Oct 20, 2021
65ca001
Merge branch 'master' into @invertase/rtdb-refactor
lesnitsky Oct 21, 2021
c4b793b
Merge branch 'master' into @invertase/rtdb-refactor
lesnitsky Oct 22, 2021
dcfc078
refactor(database): add more tests; implement missing methods and fields
lesnitsky Oct 22, 2021
383ff59
test(database): fix ordering tests on web
lesnitsky Oct 25, 2021
e28dd92
chore(database): fix analyzer
lesnitsky Oct 25, 2021
c032b45
chore(database): fix formatting
lesnitsky Oct 25, 2021
65c9c74
chore(database): fix platform interface test
lesnitsky Oct 25, 2021
384c915
chore(database): downgrade gradle version
lesnitsky Oct 25, 2021
974e4c9
refactor(database): drop unnecessary Query#buildArguments
lesnitsky Oct 25, 2021
c800da5
test(database): add test for #7221
lesnitsky Oct 25, 2021
bcf592a
test(database): add test for #7048
lesnitsky Oct 25, 2021
13b5fc4
fix(database): drop unnecessary code
lesnitsky Oct 26, 2021
a4ef68b
fix(database): fix event channels and subscription tests
lesnitsky Oct 27, 2021
10214b3
chore(database): intiialize error props in constructor instead of get…
lesnitsky Oct 27, 2021
2fedd0d
refactor(database): read error fields once instead of storing delegate
lesnitsky Oct 27, 2021
337c555
test(database): assert error code
lesnitsky Oct 27, 2021
404d725
chore(database): run melos format
lesnitsky Oct 27, 2021
92c29a9
refactor(database): drop deprecated reference
lesnitsky Oct 27, 2021
9d2f9ce
chore: wip documentation
Ehesp Oct 27, 2021
57f715f
refactor(database): take app name into account for event channel names
lesnitsky Oct 27, 2021
9d03480
refactor: additional API refactors (#7371)
Salakar Nov 24, 2021
1f9f35d
Merge branch 'master' of https://github.com/FirebaseExtended/flutterf…
Salakar Nov 24, 2021
bdede62
-
Salakar Nov 24, 2021
50529c0
-
Salakar Nov 24, 2021
28dafe6
chore: add changelog
Ehesp Nov 30, 2021
e21be78
fix: add deprecated functionality
Ehesp Nov 30, 2021
a9134cd
refactor: Transaction, TransactionHandler
Salakar Nov 30, 2021
53ecc4a
-
Salakar Nov 30, 2021
afcbbba
-
Salakar Nov 30, 2021
0c5ea53
chore: rework query logic
Ehesp Nov 30, 2021
1758f7f
chore: add tests / cleanup
Ehesp Dec 1, 2021
df926c6
chore: update test
Ehesp Dec 1, 2021
2964656
-
Salakar Dec 1, 2021
fae62ed
-
Salakar Dec 1, 2021
0a232b1
-
Salakar Dec 1, 2021
7bf74c4
chore: update tests
Ehesp Dec 1, 2021
a9122e5
-
Salakar Dec 1, 2021
3b5cd39
fix: stringify map keys
Ehesp Dec 1, 2021
78d5a64
fix: stringify map keys
Ehesp Dec 1, 2021
b29e65f
-
Salakar Dec 1, 2021
62b30fb
-
Salakar Dec 1, 2021
08ee1be
fix: update tests
Ehesp Dec 1, 2021
fdbf1a5
Merge remote-tracking branch 'origin/@invertase/rtdb-refactor' into @…
Ehesp Dec 1, 2021
bbebd1b
fix: update tests
Ehesp Dec 1, 2021
90dca1c
docs(rtdb): update README.md
russellwheatley Dec 2, 2021
cda8dfe
refactor: ios query builder to use modifiers array
Salakar Dec 2, 2021
b19b95d
remaining ios todos
Salakar Dec 2, 2021
444bb4e
ci fixes
Salakar Dec 2, 2021
ff64e47
-
Salakar Dec 2, 2021
72fe5da
-
Salakar Dec 2, 2021
f76f367
-
Salakar Dec 2, 2021
37aceb0
Merge branch 'master' into @invertase/rtdb-refactor
Salakar Dec 2, 2021
af6f3ed
-
Salakar Dec 2, 2021
0163e61
Merge branch '@invertase/rtdb-refactor' of https://github.com/Firebas…
Salakar Dec 2, 2021
2542813
-
Salakar Dec 2, 2021
65b50f1
-
Salakar Dec 3, 2021
abc653e
-
Salakar Dec 3, 2021
2758ccb
fix: apply correct cursor query on web
Ehesp Dec 3, 2021
1481076
Merge branch 'dev' of github.com:FirebaseExtended/flutterfire into @i…
Ehesp Dec 3, 2021
0f5b7e2
Merge branch 'dev' into @invertase/rtdb-refactor
Salakar Dec 3, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions .github/workflows/firebase_database.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@ on:
env:
FLUTTERFIRE_PLUGIN_SCOPE: "*firebase_database*"
FLUTTERFIRE_PLUGIN_SCOPE_EXAMPLE: "*firebase_database_example*"
# TODO(Salakar): `flutter_driver` does not yet support NNBD
FLUTTER_COMMAND_FLAGS: "--no-sound-null-safety"

jobs:
android:
Expand All @@ -34,9 +32,13 @@ jobs:
- name: "Install Flutter"
run: ./.github/workflows/scripts/install-flutter.sh stable
- name: "Install Tools"
run: ./.github/workflows/scripts/install-tools.sh
run: |
./.github/workflows/scripts/install-tools.sh
sudo npm i -g firebase-tools
- name: "Build Example"
run: ./.github/workflows/scripts/build-example.sh android
- name: Start Firebase Emulator
run: cd ./.github/workflows/scripts && ./start-firebase-emulator.sh
- name: "Drive Example"
uses: reactivecircus/android-emulator-runner@v2
with:
Expand All @@ -61,8 +63,11 @@ jobs:
run: |
./.github/workflows/scripts/install-tools.sh
flutter config --enable-macos-desktop
sudo npm i -g firebase-tools
- name: "Build iOS Example"
run: ./.github/workflows/scripts/build-example.sh ios
- name: Start Firebase Emulator
run: cd ./.github/workflows/scripts && ./start-firebase-emulator.sh
- name: "Drive iOS Example"
run: ./.github/workflows/scripts/drive-example.sh ios
- name: "Build MacOS Example"
Expand All @@ -82,6 +87,8 @@ jobs:
- name: "Install Tools"
run: |
./.github/workflows/scripts/install-tools.sh
flutter config --enable-web
sudo npm i -g firebase-tools
- name: Start Firebase Emulator
run: cd ./.github/workflows/scripts && ./start-firebase-emulator.sh
- name: "Drive Example"
run: ./.github/workflows/scripts/drive-example.sh web
33 changes: 33 additions & 0 deletions .github/workflows/scripts/database.rules.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
{
"rules": {
".read": false,
".write": false,
"denied_read": {
".read": false,
".write": false
},
"messages": {
".read": true,
".write": true
},
"counter": {
".read": true,
".write": true
},
"tests": {
".read": true,
".write": true,
".indexOn": [
".value",
"number"
],
"ordered": {
".read": true,
".write": true,
".indexOn": [
"value"
]
}
}
}
}
6 changes: 6 additions & 0 deletions .github/workflows/scripts/firebase.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@
"firestore": {
"rules": "firestore.rules"
},
"database": {
"rules": "database.rules.json"
},
"functions": {
"predeploy": "npm --prefix \"$RESOURCE_DIR\" run build",
"source": "functions"
Expand All @@ -16,6 +19,9 @@
"storage": {
"port": "9199"
},
"database": {
"port": "9000"
},
"ui": {
"enabled": true,
"port": 4000
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/scripts/functions/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"logs": "firebase functions:log"
},
"engines": {
"node": "12"
"node": "16"
},
"main": "lib/index.js",
"dependencies": {
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/scripts/start-firebase-emulator.sh
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ if [[ ! -d "functions/node_modules" ]]; then
fi

export STORAGE_EMULATOR_DEBUG=true
EMU_START_COMMAND="firebase emulators:start --only auth,firestore,functions,storage --project react-native-firebase-testing"
EMU_START_COMMAND="firebase emulators:start --only auth,firestore,functions,storage,database --project react-native-firebase-testing"

MAX_RETRIES=3
MAX_CHECKATTEMPTS=60
Expand Down Expand Up @@ -53,4 +53,4 @@ while [ $RETRIES -le $MAX_RETRIES ]; do

done
echo "Firebase Emulator Suite did not come online after $MAX_RETRIES attempts."
exit 1
exit 1
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -75,4 +75,5 @@ yarn-error.log*

firebase-debug.log
firestore-debug.log
database-debug.log
ui-debug.log
Loading