Fix Various Instances of Undefined Behaviour (#1198)

* Fix UB in bls. * Fix UB in CDKGSessionHandler::SleepBeforePhase. * Fix UB in CQuorumBlockProcessor::GetCommitmentsFromBlock.
firoorg · May 17, 2023 · f492160 · f492160
1 parent 1919d0b
commit f492160
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/src/bls/bls.h b/src/bls/bls.h
@@ -42,7 +42,7 @@ class CBLSWrapper
     friend class CBLSPublicKey;
     friend class CBLSSignature;
 
-    bool fLegacy;
+    bool fLegacy{fLegacyDefault};
 
 protected:
     ImplType impl;

diff --git a/src/llmq/quorums_blockprocessor.cpp b/src/llmq/quorums_blockprocessor.cpp
@@ -321,7 +321,8 @@ bool CQuorumBlockProcessor::GetCommitmentsFromBlock(const CBlock& block, const C
                 return state.DoS(100, false, REJECT_INVALID, "bad-qc-dup");
             }
 
-            ret.emplace((Consensus::LLMQType)qc.commitment.llmqType, std::move(qc.commitment));
+            auto llmqTypeTemp = (Consensus::LLMQType)qc.commitment.llmqType;
+            ret.emplace(llmqTypeTemp, std::move(qc.commitment));
         }
     }
 

diff --git a/src/llmq/quorums_dkgsessionhandler.cpp b/src/llmq/quorums_dkgsessionhandler.cpp
@@ -238,7 +238,8 @@ void CDKGSessionHandler::SleepBeforePhase(QuorumPhase curPhase,
         phaseTime = 0;
     }
 
-    int64_t sleepTime = (int64_t)(phaseTime * curSession->GetMyMemberIndex());
+    int64_t sleepTime = 0;
+    if (curSession->GetMyMemberIndex() != UINT64_MAX) sleepTime = (int64_t)(phaseTime * curSession->GetMyMemberIndex());
     int64_t endTime = GetTimeMillis() + sleepTime;
     while (GetTimeMillis() < endTime) {
         if (stopRequested || ShutdownRequested()) {