Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow direct lib path imports #55

Merged
merged 1 commit into from
Sep 28, 2021
Merged

Allow direct lib path imports #55

merged 1 commit into from
Sep 28, 2021

Conversation

icidasset
Copy link
Contributor

Copied from changelog:

Importing keystore-idb/lib/* directly should now work as intended. This allows bundlers to use the "real" import paths (eg. import "keystore-idb/lib/utils.js") in addition to the "proxy" import paths (eg. import "keystore-idb/utils.js"). One reason to do this could be that you want your library to support both new and old bundlers, ie. bundlers with or without exports support in their package.json file.

matheus23
matheus23 approved these changes Sep 28, 2021
View reviewed changes
Copy link
Member

@matheus23 matheus23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm. Export maps aren't quite ready yet, hm? 😭

@icidasset
Copy link
Contributor Author

If only we could stick with one bundler 😅

@icidasset icidasset merged commit 0bd4fe4 into main Sep 28, 2021
@icidasset icidasset deleted the icidasset/0.15.1 branch September 28, 2021 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matheus23 matheus23 matheus23 approved these changes

Assignees

@matheus23 matheus23

@bgins bgins

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@icidasset @matheus23 @bgins