Coordinator pipeline draft #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is, like, disappointingly void of substance. Sorry.
So, as we discussed, we want to have a separate pipeline that would accept user queries, submit them to the coordinator to create the pipeline, then submit that pipeline to the executor, which would send it to the cluster. That separate pipeline would be
CoordinatorExecutorPipeline. For now,planner,queryPlanner, etc are left as parameters, seeing as I don't know how to obtain their instances (for example, apparently, the instance ofCalciteQueryPlannerthat's used when executing a SQL query in Beam is instantiated byBeamSqlEnvusing reflection, if the code comments are to be believed? How do we get /that/...), although ideally I assume the only things that the user would need to supply are query jobs and inputs.I tried to test whether it works, but, alas, that would require me to find an
UnboundedSourceto register... should I have used the Nexmark one?