initrd-setup-root: Clean duplicate overlayfs entries #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Feb 24, 2023
This pulls in flatcar/bootengine#54 to provide a migration path and also ensure that no unwanted /etc/ upperdir files prevent using updated lowerdir files from /usr/share/flatcar/etc.
This was referenced Feb 24, 2023
pothos
force-pushed
the
kai/etc-overlay-cleanup
branch
from
345e088 to
3676aaa
Compare
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Feb 27, 2023
This pulls in flatcar/bootengine#54 to provide a migration path and also ensure that no unwanted /etc/ upperdir files prevent using updated lowerdir files from /usr/share/flatcar/etc.
pothos
force-pushed
the
kai/etc-overlay-cleanup
branch
2 times, most recently
from
8da7f57 to
85ec998
Compare
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Feb 27, 2023
This pulls in flatcar/bootengine#54 to provide a migration path and also ensure that no unwanted /etc/ upperdir files prevent using updated lowerdir files from /usr/share/flatcar/etc.
krnowak
reviewed
Feb 27, 2023
krnowak
reviewed
Feb 27, 2023
pothos
force-pushed
the
kai/etc-overlay-cleanup
branch
from
85ec998 to
90b1b53
Compare
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Feb 27, 2023
This pulls in flatcar/bootengine#54 to provide a migration path and also ensure that no unwanted /etc/ upperdir files prevent using updated lowerdir files from /usr/share/flatcar/etc.
pothos
force-pushed
the
kai/etc-overlay-cleanup
branch
2 times, most recently
from
b451800 to
2bd7fc0
Compare
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Feb 27, 2023
This pulls in flatcar/bootengine#54 to provide a migration path and also ensure that no unwanted /etc/ upperdir files prevent using updated lowerdir files from /usr/share/flatcar/etc.
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Feb 27, 2023
This pulls in flatcar/bootengine#54 to provide a migration path and also ensure that no unwanted /etc/ upperdir files prevent using updated lowerdir files from /usr/share/flatcar/etc.
krnowak
reviewed
Feb 27, 2023
pothos
force-pushed
the
kai/etc-overlay-cleanup
branch
from
2bd7fc0 to
7c1c3af
Compare
With machines having an old full /etc they would not benefit from future updates of files in /usr/share/flatcar/etc. Clean up duplicate entries to make sure that the lowerdir gets used. While this could be done in a one-time migration it is actually not bad to do this also against unwanted upcopies. The walker helper function introduced should also be used for the selective OS reset feature.
pothos
force-pushed
the
kai/etc-overlay-cleanup
branch
from
7c1c3af to
01855b1
Compare
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Feb 28, 2023
This pulls in flatcar/bootengine#54 to provide a migration path and also ensure that no unwanted /etc/ upperdir files prevent using updated lowerdir files from /usr/share/flatcar/etc.
krnowak
approved these changes
Feb 28, 2023
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Feb 28, 2023
This pulls in flatcar/bootengine#54 to provide a migration path and also ensure that no unwanted /etc/ upperdir files prevent using updated lowerdir files from /usr/share/flatcar/etc.
t-lo
pushed a commit
to flatcar/scripts
that referenced
this pull request
Apr 17, 2023
This pulls in flatcar/bootengine#54 to provide a migration path and also ensure that no unwanted /etc/ upperdir files prevent using updated lowerdir files from /usr/share/flatcar/etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With machines having an old full /etc they would not benefit from future updates of files in /usr/share/flatcar/etc. Clean up duplicate entries to make sure that the lowerdir gets used. While this could be done in a one-time migration it is actually not bad to do this also against unwanted upcopies. The walker helper function introduced should also be used for the selective OS reset feature.
How to use
Testing done
Booted the Alpha image and then ran:
This showed that most files/symlinks/dirs are gone and only changed files were left, e.g.,
/etc/hosts,/etc/profile,/etc/iscsiwere deleted but the/etc/systemd/system.conffile has a different comment because the default changed and thus this file didn't get deleted.CI
shellcheck dracut/99setup-root/initrd-setup-rootNew Kola test: flatcar/mantle#414