Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop lots of obsolete CI, release signing, and upload code #2477

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

chewi
Copy link
Contributor

@chewi chewi commented Nov 25, 2024

Drop lots of obsolete CI, release signing, and upload code

The jenkins directory has been superseded by code in the ci-automation directory.

Most of the rest hinges on the --upload option being passed, and it never is any more. Much of it also concerns Google Buckets, which we no longer use, save for some GCE-specific bits.

How to use

Nothing to use. The real acid test well be when we do an official release.

Testing done

A two-phase Jenkins run entirely passed, including the additional amd64 tests. I compared the file listings in bincache with the latest nightly and everything matched up, save for a few very minor size differences.

  • Changelog entries added in the respective changelog/ directory (user-facing change, bug fix, security fix, update) -- N/A
  • Inspected CI output for image differences: /boot and /usr size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.

@chewi chewi requested a review from a team November 25, 2024 12:57
@chewi chewi self-assigned this Nov 25, 2024
Copy link
Member

@krnowak krnowak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright for me, but it would be good if the release team has a look at it too.

This has been superseded by code in the ci-automation directory.

Signed-off-by: James Le Cuirot <[email protected]>
Most of this hinges on the --upload option being passed, and it never is
any more. Much of it also uses Google Buckets, which we no longer use,
save for some GCE-specific bits.

Signed-off-by: James Le Cuirot <[email protected]>
@chewi chewi force-pushed the chewi/drop-old-code branch from 013339d to 9f8eac6 Compare November 26, 2024 14:58
@chewi chewi requested review from sayanchowdhury and removed request for sayanchowdhury November 26, 2024 15:00
@chewi chewi merged commit 4ca21a1 into main Nov 26, 2024
1 check failed
@chewi chewi deleted the chewi/drop-old-code branch November 26, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants