Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

permission-db: Do not crash on NULL child_app_id #1649

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

A6GibKm
Copy link
Contributor

@A6GibKm A6GibKm commented Feb 21, 2025

The callers of this function check whether the return value is NULL.

Fixes: #1616

The callers of this function check whether the return value is NULL.

Fixes: flatpak#1616
@swick
Copy link
Collaborator

swick commented Feb 24, 2025

The change itself LGTM, but the underlying problem remains: somehow a NULL app_id managed to get into your permission db and that should not happen. Not sure if this really should close the reported issue.

@A6GibKm
Copy link
Contributor Author

A6GibKm commented Feb 25, 2025

$ flatpak permission-show ca.desrt.dconf-editor
Table         Object       App                   Permissions Data
notifications notification ca.desrt.dconf-editor yes         0x00
$ flatpak permissions | awk '{ print $3 }'
org.mozilla.Thunderbird
org.gnome.Calculator
org.gnome.Fractal
org.gnome.World.PikaBackup
org.gnome.clocks
ca.desrt.dconf-editor
com.github.marhkb.Pods
com.spotify.Client
im.riot.Riot
org.gnome.Builder
org.gnome.Fractal
org.gnome.World.PikaBackup
org.gnome.baobab
org.gnome.clocks
org.mozilla.Thunderbird
org.mozilla.firefox
org.signal.Signal
org.gnome.Calendar
org.gnome.Maps
org.gnome.Weather
org.mozilla.firefox
com.belmoussaoui.ashpd.demo
org.mozilla.firefox
org.mozilla.firefox
org.mozilla.firefox
org.mozilla.firefox
org.mozilla.firefox
org.mozilla.firefox

Is there something I am missing? It does not look to have any NULL app id. Is there any way manually inspect the permissions on this machine?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xdg-permission-store: Crash inside get_app_permissions
2 participants