realtime: Include PID/TID in some error messages #1655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jadahl
reviewed
Feb 26, 2025
src/realtime.c
Outdated
| g_warning ("Realtime error: %s", (*error)->message); | ||
| return FALSE; | ||
| } | ||
|
|
||
| if (pidns_id != 0 && !xdp_map_tids (pidns_id, *pid, tid, 1, error)) | ||
| { | ||
| g_prefix_error (error, "Could not map tid: "); | ||
| g_prefix_error (error, "Could not map tid %d of pid %d: ", *tid, *pid); |
There was a problem hiding this comment.
This will log the mapped pid, the other will log the unmapped pid. That might be confusing if not explicit, e.g. "of mapped pid %d" or "of pid %d mapped to %d" or something.
There was a problem hiding this comment.
Good point - updated to "mapped pid". The original pid would need to be stored separately if we wanted to print it here - seems like overkill unless a use case pops up for this particular message.
andrew-sayers
force-pushed
the
realtime-error-pid
branch
from
c541dcc to
d773b9e
Compare
swick
reviewed
Feb 26, 2025
andrew-sayers
force-pushed
the
realtime-error-pid
branch
from
d773b9e to
ce776d9
Compare
The PID is useful when debugging issues related to these messages, so we can check whether the PID has some strange property that caused the problem.
|
LGTM |
andrew-sayers
force-pushed
the
realtime-error-pid
branch
from
ce776d9 to
eddeed3
Compare
For the record, I was adding the comment at the top of the patch at the same time @swick was typing this, based on feedback in the now-resolved discussion. The PR is otherwise identical. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PID is useful when debugging issues related to these messages, so we can check whether the PID has some strange property that caused the problem.
In my case, this made it easier to debug #1653 - the PID showed it was caused by Firefox, so I knew to look there.