Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YAML VPP app custom target changes not applied when going from "include any" to "exclude any" #26290

Closed
jmwatts opened this issue Feb 12, 2025 · 2 comments
Assignees
Labels
bug Something isn't working as documented #g-software Software product group :incoming New issue in triage process. :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. ~unreleased bug This bug was found in an unreleased version of Fleet.
Milestone

Comments

@jmwatts
Copy link
Member

jmwatts commented Feb 12, 2025

Fleet version: 4.64.0

Web browser and operating system: n/a


💥  Actual behavior

Custom target changes are not applied when going from "include any" to "exclude any"
Going from "exclude any" to "include any" works for App Store apps.
Going from "include any" to "exclude any" works for regular software packages, just not App Store apps.

🧑‍💻  Steps to reproduce

  1. Ensure you have a VPP token uploaded to Fleet and it is assigned to the team you will be using.
  2. Using an existing team YAML file, or create a new team YAML file to add an App Store App to your team using GitOps workflow OR fleetctl apply command. Example YAML file is attached - if using, be sure to remove the .txt extension, update the YAML file with the correct team name and the adam ID of an App Store app that exists on your VPP token.
  3. Log in to fleetctl and run 'fleetctl apply -f /path/to/saved/team.yml`
  4. Verify the App Store app has been added with the appropriate custom scoping
  5. Edit the YAML file, change "labels_include_any:" to "labels_exclude_any:"
  6. run 'fleetctl apply -f /path/to/saved/team.yml` again

team_example.yml.txt

🕯️ Expected

Custom target changes should be changed from "include any" to "exclude any"

@jmwatts jmwatts added #g-software Software product group :incoming New issue in triage process. :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. bug Something isn't working as documented ~unreleased bug This bug was found in an unreleased version of Fleet. labels Feb 12, 2025
@jmwatts jmwatts added this to the 4.64.0 milestone Feb 12, 2025
jahzielv added a commit that referenced this issue Feb 12, 2025
…26302)

> For #26290

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

<!-- Note that API documentation changes are now addressed by the
product design team. -->

- [x] Added/updated automated tests
- [x] Manual QA for all new/changed functionality
jahzielv added a commit that referenced this issue Feb 12, 2025
…26302)

> For #26290

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

<!-- Note that API documentation changes are now addressed by the
product design team. -->

- [x] Added/updated automated tests
- [x] Manual QA for all new/changed functionality
@jmwatts
Copy link
Member Author

jmwatts commented Feb 12, 2025

QA Notes

  1. Ensure you have a VPP token uploaded to Fleet and it is assigned to the team you will be using.
  2. Using an existing team YAML file, or create a new team YAML file to add an App Store App to your team using GitOps workflow OR fleetctl apply command. Example YAML file is attached - if using, be sure to remove the .txt extension, update the YAML file with the correct team name and the adam ID of an App Store app that exists on your VPP token.
  3. Log in to fleetctl and run 'fleetctl apply -f /path/to/saved/team.yml`
  4. Verify the App Store app has been added with the appropriate custom scoping
  5. Edit the YAML file, change scoping for the following scenarios one by one
  6. run 'fleetctl apply -f /path/to/saved/team.yml` again
  • Include any -> exclude any
  • Exclude any -> include any
  • no custom scope -> include any
  • custom scope -> all hosts
  • no custom scope -> exclude any

@fleet-release
Copy link
Contributor

YAML VPP changes,
Like leaves in the wind shifting.
Ease in every task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as documented #g-software Software product group :incoming New issue in triage process. :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. ~unreleased bug This bug was found in an unreleased version of Fleet.
Projects
None yet
Development

No branches or pull requests

4 participants