Use custom ComposeCoroutineScope instead of LifecycleScope in Jetpack…

… Compose Example
floschu · May 21, 2020 · 6d22578 · 6d22578
1 parent 75a61b1
commit 6d22578
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 3 deletions.
diff --git a/...er-compose/src/main/kotlin/at/florianschuster/control/androidcountercomposeexample/App.kt b/...er-compose/src/main/kotlin/at/florianschuster/control/androidcountercomposeexample/App.kt
@@ -4,9 +4,7 @@ import android.os.Bundle
 import androidx.activity.ComponentActivity
 import androidx.compose.Composable
 import androidx.compose.getValue
-import androidx.lifecycle.lifecycleScope
 import androidx.ui.core.ContextAmbient
-import androidx.ui.core.LifecycleOwnerAmbient
 import androidx.ui.core.setContent
 import androidx.ui.foundation.Text
 import androidx.ui.foundation.isSystemInDarkTheme
@@ -29,7 +27,7 @@ internal class AppActivity : ComponentActivity() {
 
 @Composable
 private fun AppScreen() {
-    val controller = LifecycleOwnerAmbient.current.lifecycleScope.createCounterController()
+    val controller = ComposeCoroutineScope().createCounterController()
     MaterialTheme(colors = AppColors.currentColorPalette) {
         Scaffold(
             topAppBar = {

diff --git a/...ose/src/main/kotlin/at/florianschuster/control/androidcountercomposeexample/extensions.kt b/...ose/src/main/kotlin/at/florianschuster/control/androidcountercomposeexample/extensions.kt
@@ -3,7 +3,26 @@ package at.florianschuster.control.androidcountercomposeexample
 import androidx.compose.Composable
 import androidx.compose.State
 import androidx.compose.collectAsState
+import androidx.compose.onDispose
+import androidx.compose.remember
 import at.florianschuster.control.Controller
+import kotlinx.coroutines.CoroutineScope
+import kotlinx.coroutines.Dispatchers
+import kotlinx.coroutines.SupervisorJob
+import kotlinx.coroutines.cancel
+import kotlin.coroutines.CoroutineContext
+
+/**
+ * Creates a [CoroutineScope] with [coroutineContext] that lives until [onDispose].
+ */
+@Composable
+internal fun ComposeCoroutineScope(
+    coroutineContext: CoroutineContext = SupervisorJob() + Dispatchers.Main.immediate
+): CoroutineScope {
+    val scope = remember(coroutineContext) { CoroutineScope(coroutineContext) }
+    onDispose { scope.cancel() }
+    return scope
+}
 
 /**
  * Collects values from the [Controller.state] and represents its latest value via [State].