Lazily start the controller when accessing the effects property #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
floschu
force-pushed
the
release/0.14.0
branch
2 times, most recently
from
a023cb2 to
8080546
Compare
|
Looks good 👍 |
FlowMo7
force-pushed
the
issue/26_controller_not_lazily_started_on_effect_getter
branch
from
8df38ac to
c71f6ad
Compare
|
Thank you. Fixed within #28 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26.
The implemented test case fails when not applying the given fix, and is green when applying the fixes.
The test was only quickly implemented, please feel free to adjust the test case to match your preferred test code formatting / organization.