Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update S3 SDK + fix region access in tests #305

Merged
merged 1 commit into from
Jan 14, 2020
Merged

update S3 SDK + fix region access in tests #305

merged 1 commit into from
Jan 14, 2020

Conversation

bonifaido
Copy link
Contributor

@bonifaido bonifaido commented Jan 10, 2020

Signed-off-by: Nandor Kracser [email protected]

This allows us to use the most recent AWS S3 and STS Ruby SDKs and fixes the build as well.

Fixes: #301

Signed-off-by: Nandor Kracser <[email protected]>
@bonifaido bonifaido marked this pull request as ready for review January 10, 2020 08:44
@bonifaido bonifaido changed the title fix region access in tests update S3 SDK + fix region access in tests Jan 10, 2020
@dnascimento
Copy link

Would this support regional sts endpoint?

@bonifaido
Copy link
Contributor Author

This only upgrades the AWS SDK and fixes a test issue which is caused by the update.

@ganmacs ganmacs merged commit c6e8576 into fluent:master Jan 14, 2020
@ganmacs
Copy link
Member

ganmacs commented Jan 14, 2020

thanks!

@bonifaido bonifaido deleted the update-aws-sdks branch January 14, 2020 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Support for IAM Roles for Service accounts (IRSA)
3 participants