-
-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add show hidden option to outputs panel #1209
Open
TomW1605
wants to merge
33
commits into
fluidd-core:develop
Choose a base branch
from
TomW1605:develop
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
0e374f2
add show hidden option to outputs panel
TomW1605 182fa42
fix formatting
TomW1605 4da0ce1
Merge branch 'develop' into develop
TomW1605 fa59f8e
fix warnings from build action
TomW1605 bc35ee1
Merge branch 'develop' into develop
TomW1605 c382a3c
Merge branch 'develop' into develop
pedrolamas 468e572
Merge branch 'develop' into develop
TomW1605 79109b8
Merge branch 'develop' into develop
pedrolamas 6508c6a
Merge branch 'develop' into develop
TomW1605 851028f
Merge branch 'develop' into develop
TomW1605 edd431a
Merge branch 'develop' into develop
TomW1605 fb30fe8
Merge branch 'develop' into develop
TomW1605 d1fa6fb
Merge branch 'develop' into develop
TomW1605 c448b0b
Merge branch 'develop' into develop
TomW1605 487360c
simplify layout
TomW1605 cdf65fd
simplify if
TomW1605 3205f8c
rename setting to showHiddenOutputs
TomW1605 c17febe
Merge branch 'develop' into develop
TomW1605 d5fcd50
Merge branch 'develop' into develop
pedrolamas 3eda87f
Merge branch 'develop' into develop
TomW1605 0b9d8fd
Merge branch 'develop' into develop
pedrolamas c1084b1
fix output card not showing
TomW1605 af7fa84
Merge branch 'develop' into develop
TomW1605 bb88a4e
Merge branch 'develop' into develop
TomW1605 446970f
Merge branch 'develop' into develop
TomW1605 d25f257
Merge branch 'develop' into develop
TomW1605 34fd9ac
Merge branch 'develop' into develop
TomW1605 9484389
Merge branch 'develop' into develop
TomW1605 5c42f3c
Merge branch 'develop' into develop
TomW1605 c7b4ff7
Merge branch 'develop' into develop
TomW1605 a9af8a9
Merge branch 'develop' into develop
TomW1605 81d904e
Merge remote-tracking branch 'upstream/develop' into develop
TomW1605 b0cf956
Merge branch 'develop' into develop
TomW1605 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strings like this need to be localizable, so it should move to "en.yaml" and consumed with
$t(app....)
so it can be translatedThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, forgot to do that. will fix it this weekend
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets also make this "Show hidden outputs" to make it more descriptive and distinct from any other.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, got the other things done. where do you recomend putting this in the translation files?