Testing callbacks against the Capistrano config's list of callbacks #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. this helps reduce the possibility of false positives on tests in cases where callbacks are being tested on partial capistrano configurations
|
Woot, pulled! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Fletcher,
I made a change to the test_callback_on() method so that it tests against the list of callbacks in the Capistrano config instead of the relationship between a task and callback.
I found that Capistrano always returned true for Capistrano::TaskCallback.applies_to?(task) if task is nil and that gave me a few false positives on some tests I was writing.