fix(fzf-lua): update update_title and update_scrollbar to update_preview_title and update_preview_scrollbar
#1034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did this locally as well. This is needed for the fzf lua integration to work. |
This was referenced Jan 29, 2025
Closed
|
ty |
folke
pushed a commit
that referenced
this pull request
Feb 6, 2025
## Description `<leader>snt` wasn't working properly - the same fzf compatibility update as #1034 - the hl_group update from #1032 but for `fzf.lua` Those PRs should probably merged instead of this, but the hl_group update one also needs to update `lua/noice/integrations/fzf.lua` Figured I'd submit this to bump visibility of the issue. ## Related Issue(s) #1029 #1024
folke
pushed a commit
that referenced
this pull request
Feb 6, 2025
🤖 I have created a release *beep* *boop* --- ## [4.10.0](v4.9.0...v4.10.0) (2025-02-06) ### Features * **fzf:** fix fzf integration ([#1048](#1048)) ([f3291db](f3291db)) ### Bug Fixes * **cmdline:** use number indexed `vim.g.ui_cmdline_pos` ([eaed6cc](eaed6cc)) * **confirm:** fixed `vim.fn.confirm` on nightly (0.11). Closes [#1036](#1036) ([00b5984](00b5984)) * **fzf-lua:** update `update_title` and `update_scrollbar` to `update_preview_title` and `update_preview_scrollbar` ([#1034](#1034)) ([5530d78](5530d78)), closes [#1029](#1029) * **nui:** don't error when border win was closed. Fixes [#832](#832) ([d2b092a](d2b092a)) * **telescope:** handle hl_group ID correctly in picker ([#1032](#1032)) ([002b202](002b202)), closes [#1024](#1024) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
FzfWin:update_titleandFzfWin:update_scrollbarwere changed toFzfWin:update_preview_titleandFzfWin:update_preview_scroolbarsince ibhagwan/fzf-lua@fc70792It will make an error when opening message history with fzf-lua
:Noice fzfRelated Issue(s)
Fixes #1029